[SPARK-23356][SQL][TEST] add new test cases for a + 1,a + b and Rand in SetOperationSuite #23138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #99249 has finished for PR 23138 at commit
|
heary-cao
force-pushed
the
UnionPushTestCases
branch
from
8245fed to
ebe10e1
Compare
heary-cao
changed the title
|
Test build #99253 has finished for PR 23138 at commit
|
Contributor
Author
|
retest this please |
gatorsmile
reviewed
Nov 26, 2018
Member
There was a problem hiding this comment.
are addition to each side -> are pushed down
gatorsmile
reviewed
Nov 26, 2018
gatorsmile
reviewed
Nov 26, 2018
Member
There was a problem hiding this comment.
no pushdown for non-deterministic expression
heary-cao
force-pushed
the
UnionPushTestCases
branch
from
ebe10e1 to
471d114
Compare
|
Test build #99260 has finished for PR 23138 at commit
|
|
Test build #99265 has finished for PR 23138 at commit
|
|
Test build #99261 has finished for PR 23138 at commit
|
Contributor
Author
|
retest this please |
|
Test build #99272 has finished for PR 23138 at commit
|
srowen
approved these changes
Nov 26, 2018
cloud-fan
reviewed
Nov 26, 2018
Contributor
There was a problem hiding this comment.
expressions with number -> expressions with literal
heary-cao
force-pushed
the
UnionPushTestCases
branch
from
471d114 to
5ef0035
Compare
|
Test build #99300 has finished for PR 23138 at commit
|
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@cloud-fan, @gatorsmile, @srowen thanks. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…in SetOperationSuite ## What changes were proposed in this pull request? The purpose of this PR is supplement new test cases for a + 1,a + b and Rand in SetOperationSuite. It comes from the comment of closed PR:apache#20541, thanks. ## How was this patch tested? add new test cases Closes apache#23138 from heary-cao/UnionPushTestCases. Authored-by: caoxuewen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The purpose of this PR is supplement new test cases for a + 1,a + b and Rand in SetOperationSuite.
It comes from the comment of closed PR:#20541, thanks.
How was this patch tested?
add new test cases