Skip to content

[SPARK-25685][BUILD] Allow running tests in Jenkins in enterprise Git repository #22678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LantaoJin wants to merge 8 commits into from
Closed

[SPARK-25685][BUILD] Allow running tests in Jenkins in enterprise Git repository #22678

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc34da8
[SPARK-25685][BUILD] Allow regression testing in enterprise Jenkins
LantaoJin Oct 9, 2018
0df4c61
reuse existed env variable name
LantaoJin Oct 10, 2018
a45c373
documentation in building-spark
LantaoJin Oct 11, 2018
c435242
remove pronoun
LantaoJin Oct 11, 2018
d439397
address comment
LantaoJin Oct 11, 2018
dc47b08
address comments
LantaoJin Oct 11, 2018
c42fd58
address comment
LantaoJin Oct 11, 2018
d8e7ad0
address comments
LantaoJin Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dev/run-tests-jenkins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def print_err(msg):
def post_message_to_github(msg, ghprb_pull_id):
print("Attempting to post to Github...")

url = "https://api.github.com/repos/apache/spark/issues/" + ghprb_pull_id + "/comments"
api_url = os.getenv("GITHUB_SERVER_API_URL", "https://api.github.com/repos/apache/spark")
Copy link
Member

@kiszk kiszk Oct 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about GITHUB_API_BASE? This is because another script uses this name for this URL.

Copy link
Contributor Author

@LantaoJin LantaoJin Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. @kiszk

url = api_url + "/issues/" + ghprb_pull_id + "/comments"
github_oauth_key = os.environ["GITHUB_OAUTH_KEY"]

posted_message = json.dumps({"body": msg})
Expand Down Expand Up @@ -176,7 +177,8 @@ def main():
build_display_name = os.environ["BUILD_DISPLAY_NAME"]
build_url = os.environ["BUILD_URL"]

commit_url = "https://github.com/apache/spark/commit/" + ghprb_actual_commit
project_url = os.getenv("SPARK_PROJECT_URL", "https://github.com/apache/spark")
commit_url = project_url + "/commit/" + ghprb_actual_commit

# GitHub doesn't auto-link short hashes when submitted via the API, unfortunately. :(
short_commit_hash = ghprb_actual_commit[0:7]
Expand Down