[SPARK-25685][BUILD] Allow running tests in Jenkins in enterprise Git repository #22678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LantaoJin
changed the title
srowen
approved these changes
Oct 9, 2018
|
Test build #4363 has finished for PR 22678 at commit
|
kiszk
reviewed
Oct 10, 2018
dev/run-tests-jenkins.py
Outdated
| print("Attempting to post to Github...") | ||
|
|
||
| url = "https://api.github.com/repos/apache/spark/issues/" + ghprb_pull_id + "/comments" | ||
| api_url = os.getenv("GITHUB_SERVER_API_URL", "https://api.github.com/repos/apache/spark") |
Member
There was a problem hiding this comment.
How about GITHUB_API_BASE? This is because another script uses this name for this URL.
Contributor
Author
|
Sorry for closing the conversation mistakenly @dongjoon-hyun . I will update the documentation soon. |
felixcheung
approved these changes
Oct 11, 2018
docs/building-spark.md
Outdated
| ### Related environment variables | ||
|
|
||
| <table class="table"> | ||
| <tr><th>variable Name</th><th>Default</th><th>Meaning</th></tr> |
kiszk
reviewed
Oct 11, 2018
docs/building-spark.md
Outdated
|
|
||
| Otherwise, the sbt-pom-reader plugin will use the `scala.version` specified in the spark-parent pom. | ||
|
|
||
| ## Running Jenkins tests with enterprise Github |
Member
There was a problem hiding this comment.
enterprise Github -> GitHub Enterprise
kiszk
reviewed
Oct 11, 2018
docs/building-spark.md
Outdated
|
|
||
| ./dev/run-tests-jenkins | ||
|
|
||
| If use an individual repository or an enterprise GitHub, export below environment variables before running above command. |
Member
There was a problem hiding this comment.
How about an enterprise GitHub -> a repository on GitHub Enterprise?
kiszk
reviewed
Oct 11, 2018
docs/building-spark.md
Outdated
| <td><code>GITHUB_API_BASE</code></td> | ||
| <td>https://api.github.com/repos/apache/spark</td> | ||
| <td> | ||
| The GitHub server API URL. It could be pointed to an enterprise GitHub. |
Member
There was a problem hiding this comment.
an enterprise GitHub -> GitHub Enterprise`
kiszk
reviewed
Oct 11, 2018
docs/building-spark.md
Outdated
| <td><code>SPARK_PROJECT_URL</code></td> | ||
| <td>https://github.com/apache/spark</td> | ||
| <td> | ||
| The Spark project URL of (enterprise) GitHub. |
kiszk
reviewed
Oct 11, 2018
docs/building-spark.md
Outdated
|
|
||
| ./dev/run-tests-jenkins | ||
|
|
||
| If use an individual repository or an GitHub Enterprise, export below environment variables before running above command. |
Member
There was a problem hiding this comment.
nit: an -> a
In addition, how about an GitHub Enterprise -> a repository on GitHub Enterprise?
kiszk
reviewed
Oct 11, 2018
docs/building-spark.md
Outdated
| <td><code>GITHUB_API_BASE</code></td> | ||
| <td>https://api.github.com/repos/apache/spark</td> | ||
| <td> | ||
| The GitHub server API URL. It could be pointed to an GitHub Enterprise. |
Member
|
retest this please |
Member
|
LGTM, pending Jenkins |
|
Test build #97303 has finished for PR 22678 at commit
|
Member
|
Merged to master |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
… repository ## What changes were proposed in this pull request? Many companies have their own enterprise GitHub to manage Spark code. To build and test in those repositories with Jenkins need to modify this script. So I suggest to add some environment variables to allow regression testing in enterprise Jenkins instead of default Spark repository in GitHub. ## How was this patch tested? Manually test. Closes apache#22678 from LantaoJin/SPARK-25685. Lead-authored-by: lajin <[email protected]> Co-authored-by: LantaoJin <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Many companies have their own enterprise GitHub to manage Spark code. To build and test in those repositories with Jenkins need to modify this script.
So I suggest to add some environment variables to allow regression testing in enterprise Jenkins instead of default Spark repository in GitHub.
How was this patch tested?
Manually test.