Skip to content

Conversation

@adrian-wang
Copy link
Contributor

In JVM 1.8.0, MaxPermSize is no longer supported.
In spark stderr output, there would be a line of

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0

@adrian-wang
Copy link
Contributor Author

@aarondav I have modified codes according to your comments, and since I did a rebase, I have to start a new PR...

@SparkQA
Copy link

SparkQA commented Aug 18, 2014

QA tests have started for PR 2011 at commit ef1d660.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 18, 2014

QA tests have finished for PR 2011 at commit ef1d660.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@adrian-wang adrian-wang changed the title remove MaxPermSize option for jvm 1.8 [SPARK-3068]remove MaxPermSize option for jvm 1.8 Aug 18, 2014
@pwendell
Copy link
Contributor

This seems like a reasonable change. One issue is it does run the java binary an extra time on task lunch, but that seems fairly cheap when only asking for the version

@asfgit asfgit closed this in f3d65cd Aug 23, 2014
@adrian-wang adrian-wang deleted the maxpermsize branch August 25, 2014 08:29
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
In JVM 1.8.0, MaxPermSize is no longer supported.
In spark `stderr` output, there would be a line of

    Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0

Author: Daoyuan Wang <[email protected]>

Closes apache#2011 from adrian-wang/maxpermsize and squashes the following commits:

ef1d660 [Daoyuan Wang] direct get java version in runtime
37db9c1 [Daoyuan Wang] code refine
3c1d554 [Daoyuan Wang] remove MaxPermSize option for jvm 1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants