[SPARK-3068]remove MaxPermSize option for jvm 1.8 #1967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 1967 at commit
|
|
QA tests have finished for PR 1967 at commit
|
Contributor
There was a problem hiding this comment.
Is all this code and munging in case JAVA_HOME is not the same Java as the Worker was started with? Otherwise it seems we could just do sys.env("java.version").
Contributor
Author
There was a problem hiding this comment.
We are now using the java which the worker started with to run executor, so to judge perm size setting we should refer to the specific java version.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JVM 1.8.0, MaxPermSize is no longer supported.
In spark
stderroutput, there would be a line of