Skip to content

[SQL] logWarning should be logInfo in getResultSetSchema #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scwf wants to merge 1 commit into from
Closed

[SQL] logWarning should be logInfo in getResultSetSchema #1939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class SparkSQLOperationManager(hiveContext: HiveContext) extends OperationManage
}

def getResultSetSchema: TableSchema = {
logWarning(s"Result Schema: ${result.queryExecution.analyzed.output}")
logInfo(s"Result Schema: ${result.queryExecution.analyzed.output}")
Copy link
Contributor

@marmbrus marmbrus Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe even logDebug? This seems pretty noisy.

Copy link
Contributor Author

@scwf scwf Aug 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think logInfo is ok, it's acceptable of each sql print once

Copy link
Contributor

@marmbrus marmbrus Aug 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah either way. I just think I wrote this line initially and it was for debugging :)

if (result.queryExecution.analyzed.output.size == 0) {
new TableSchema(new FieldSchema("Result", "string", "") :: Nil)
} else {
Expand Down