Skip to content

[SQL] logWarning should be logInfo in getResultSetSchema #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scwf wants to merge 1 commit into from
Closed

[SQL] logWarning should be logInfo in getResultSetSchema #1939

scwf wants to merge 1 commit into from

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented Aug 14, 2014

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented Aug 14, 2014

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

marmbrus commented Aug 14, 2014

ok to test

marmbrus
marmbrus reviewed Aug 14, 2014
View reviewed changes
.../src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala
Copy link
Contributor

@marmbrus marmbrus Aug 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe even logDebug? This seems pretty noisy.

Copy link
Contributor Author

@scwf scwf Aug 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think logInfo is ok, it's acceptable of each sql print once

Copy link
Contributor

@marmbrus marmbrus Aug 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah either way. I just think I wrote this line initially and it was for debugging :)

@SparkQA
Copy link

SparkQA commented Aug 14, 2014

QA tests have started for PR 1939. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18548/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 14, 2014

QA results for PR 1939:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18548/consoleFull

@scwf
Copy link
Contributor Author

scwf commented Aug 15, 2014

@marmbrus, the test error in pyspark again~

asfgit pushed a commit that referenced this pull request Aug 26, 2014
@scwf @marmbrus
[SQL] logWarning should be logInfo in getResultSetSchema
957b356 
Author: wangfei <[email protected]>

Closes #1939 from scwf/patch-5 and squashes the following commits:

f952d10 [wangfei] [SQL] logWarning should be logInfo in getResultSetSchema

(cherry picked from commit 507a1b5)
Signed-off-by: Michael Armbrust <[email protected]>
@marmbrus
Copy link
Contributor

marmbrus commented Aug 26, 2014

Thanks, I've merged this into master and 1.1.

@asfgit asfgit closed this in 507a1b5 Aug 26, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@scwf @conviva-zz
[SQL] logWarning should be logInfo in getResultSetSchema
5dab739 
Author: wangfei <[email protected]>

Closes apache#1939 from scwf/patch-5 and squashes the following commits:

f952d10 [wangfei] [SQL] logWarning should be logInfo in getResultSetSchema
@scwf scwf deleted the patch-5 branch January 7, 2015 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scwf @AmplabJenkins @marmbrus @SparkQA