Skip to content

[SPARK-21575][SparkR] Eliminate needless synchronization in java-R serialization #18775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SereneAnt wants to merge 1 commit into from
Closed

[SPARK-21575][SparkR] Eliminate needless synchronization in java-R serialization #18775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions core/src/main/scala/org/apache/spark/api/r/JVMObjectTracker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,7 @@ private[r] class JVMObjectTracker {
/**
* Returns the JVM object associated with the input key or None if not found.
*/
final def get(id: JVMObjectId): Option[Object] = this.synchronized {
if (objMap.containsKey(id)) {
Some(objMap.get(id))
} else {
None
}
}
final def get(id: JVMObjectId): Option[Object] = Option(objMap.get(id))

/**
* Returns the JVM object associated with the input key or throws an exception if not found.
Expand All @@ -67,13 +61,7 @@ private[r] class JVMObjectTracker {
/**
* Removes and returns a JVM object with the specific ID from the tracker, or None if not found.
*/
final def remove(id: JVMObjectId): Option[Object] = this.synchronized {
if (objMap.containsKey(id)) {
Some(objMap.remove(id))
} else {
None
}
}
final def remove(id: JVMObjectId): Option[Object] = Option(objMap.remove(id))

/**
* Number of JVM objects being tracked.
Expand Down