Skip to content

[SPARK-21575][SparkR] Eliminate needless synchronization in java-R serialization #18775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SereneAnt wants to merge 1 commit into from
Closed

[SPARK-21575][SparkR] Eliminate needless synchronization in java-R serialization #18775

SereneAnt wants to merge 1 commit into from

Conversation

@SereneAnt
Copy link
Contributor

@SereneAnt SereneAnt commented Jul 30, 2017

What changes were proposed in this pull request?

Remove surplus synchronized blocks.

How was this patch tested?

Unit tests run OK.

@SereneAnt SereneAnt changed the title [SPARK-8577][SparkR] Eliminate needless synchronization in java-R serialization [SPARK-21575][SparkR] Eliminate needless synchronization in java-R serialization Jul 30, 2017
@SereneAnt SereneAnt force-pushed the eliminate_unnecessary_synchronization_in_java-R_serialization branch from eafad7d to aeee08f Compare July 30, 2017 06:12
srowen
srowen approved these changes Jul 30, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. A lock is still acquired, but just the map's lock. Less work is done too. That can help a little.

@SparkQA
Copy link

SparkQA commented Jul 30, 2017

Test build #3863 has finished for PR 18775 at commit aeee08f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jiangxb1987
jiangxb1987 approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanboliang
yanboliang approved these changes Jul 31, 2017
View reviewed changes
Copy link
Contributor

@yanboliang yanboliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanboliang
Copy link
Contributor

yanboliang commented Jul 31, 2017

Merged into master, thanks for all.

@asfgit asfgit closed this in 106eaa9 Jul 31, 2017
@SereneAnt SereneAnt deleted the eliminate_unnecessary_synchronization_in_java-R_serialization branch July 31, 2017 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@jiangxb1987 jiangxb1987 jiangxb1987 approved these changes

+1 more reviewer

@yanboliang yanboliang yanboliang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SereneAnt @SparkQA @yanboliang @srowen @jiangxb1987