Skip to content

[SPARK-19857][yarn] Correctly calculate next credential update time. #17198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanzin wants to merge 1 commit into from
Closed

[SPARK-19857][yarn] Correctly calculate next credential update time. #17198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...anagers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ private[spark] class CredentialUpdater(
if (remainingTime <= 0) {
credentialUpdater.schedule(credentialUpdaterRunnable, 1, TimeUnit.MINUTES)
} else {
logInfo(s"Scheduling credentials refresh from HDFS in $remainingTime millis.")
logInfo(s"Scheduling credentials refresh from HDFS in $remainingTime ms.")
credentialUpdater.schedule(credentialUpdaterRunnable, remainingTime, TimeUnit.MILLISECONDS)
}
}
Expand All @@ -81,8 +81,8 @@ private[spark] class CredentialUpdater(
UserGroupInformation.getCurrentUser.addCredentials(newCredentials)
logInfo("Credentials updated from credentials file.")

val remainingTime = getTimeOfNextUpdateFromFileName(credentialsStatus.getPath)
- System.currentTimeMillis()
val remainingTime = (getTimeOfNextUpdateFromFileName(credentialsStatus.getPath)
- System.currentTimeMillis())
if (remainingTime <= 0) TimeUnit.MINUTES.toMillis(1) else remainingTime
} else {
// If current credential file is older than expected, sleep 1 hour and check again.
Expand All @@ -100,6 +100,7 @@ private[spark] class CredentialUpdater(
TimeUnit.HOURS.toMillis(1)
}

logInfo(s"Scheduling credentials refresh from HDFS in $timeToNextUpdate ms.")
credentialUpdater.schedule(
credentialUpdaterRunnable, timeToNextUpdate, TimeUnit.MILLISECONDS)
}
Expand Down