[SPARK-19857][yarn] Correctly calculate next credential update time. #17198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parentheses so that both lines form a single statement; also add a log message so that the issue becomes more explicit if it shows up again. Tested manually with integration test that exercises the feature.
Contributor
|
lgtm I couldn't believe this at first, I had to verify by running this for myself: scala> :paste
// Entering paste mode (ctrl-D to finish)
val x = 7
- 1
// Exiting paste mode, now interpreting.
x: Int = 7
res0: Int = -1 |
|
Test build #74143 has finished for PR 17198 at commit
|
Contributor
|
This is one of the scarey bugs I see in scala code ... the benefits of an explicit delimiter ! LGTM |
Member
|
Scalac flags some forms of this as does IJ but here the dangling line had a side effect so isn't obvious it isn't on purpose to the analyzer I guess |
Contributor
Author
|
Merging to master / 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Mar 8, 2017
Add parentheses so that both lines form a single statement; also add a log message so that the issue becomes more explicit if it shows up again. Tested manually with integration test that exercises the feature. Author: Marcelo Vanzin <[email protected]> Closes #17198 from vanzin/SPARK-19857. (cherry picked from commit 8e41c2e) Signed-off-by: Marcelo Vanzin <[email protected]>
Contributor
|
Thanks @vanzin for this fix. Sorry to bring in this bug, haven't noticed this Scala formatting issue before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses so that both lines form a single statement; also add
a log message so that the issue becomes more explicit if it shows up
again.
Tested manually with integration test that exercises the feature.