[Build] Specify release in maven-compiler-plugin configuration on JDK11#10343
Merged
merlimat merged 2 commits intoapache:masterfrom Apr 25, 2021
Merged
[Build] Specify release in maven-compiler-plugin configuration on JDK11#10343merlimat merged 2 commits intoapache:masterfrom
merlimat merged 2 commits intoapache:masterfrom
Conversation
Member
Author
|
/pulsarbot run-failure-checks |
merlimat
approved these changes
Apr 23, 2021
Member
Author
|
/pulsarbot run-failure-checks |
3 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 14, 2021
…11 (apache#10343) * Specify release in maven-compiler-plugin configuration * Use "8" instead of "1.8" (cherry picked from commit e5a2c5f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8445
Motivation
Specifying "release" parameter for maven-compiler-plugin is required on JDK11 to fix binary compatibility with JDK 8.
This blog post describes the problem and the solution: https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/
Modifications