Skip to content

Commit e5a2c5f

Browse files
authored
[Build] Specify release in maven-compiler-plugin configuration on JDK11 (#10343)
* Specify release in maven-compiler-plugin configuration * Use "8" instead of "1.8"
1 parent 3f03be0 commit e5a2c5f

File tree

1 file changed

+20
-3
lines changed

1 file changed

+20
-3
lines changed

pom.xml

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ flexible messaging model and an intuitive client API.</description>
7777
</issueManagement>
7878

7979
<properties>
80-
<maven.compiler.source>1.8</maven.compiler.source>
81-
<maven.compiler.target>1.8</maven.compiler.target>
80+
<maven.compiler.source>8</maven.compiler.source>
81+
<maven.compiler.target>8</maven.compiler.target>
8282

8383
<!--config keys to congiure test selection -->
8484
<include>**/Test*.java,**/*Test.java,**/*Tests.java,**/*TestCase.java</include>
@@ -1667,13 +1667,30 @@ flexible messaging model and an intuitive client API.</description>
16671667

16681668
<profiles>
16691669
<profile>
1670-
<id>jdk11-tests</id>
1670+
<id>jdk11</id>
16711671
<activation>
16721672
<jdk>[11,)</jdk>
16731673
</activation>
16741674
<properties>
1675+
<!-- prevents silent NoSuchMethodErrors that happen at runtime on Java 8 -->
1676+
<!-- see https://github.com/apache/pulsar/issues/8445 -->
1677+
<maven.compiler.release>${maven.compiler.target}</maven.compiler.release>
1678+
<!-- required for running tests on JDK11+ -->
16751679
<test.additional.args> --add-opens java.base/jdk.internal.loader=ALL-UNNAMED </test.additional.args>
16761680
</properties>
1681+
<build>
1682+
<pluginManagement>
1683+
<plugins>
1684+
<plugin>
1685+
<artifactId>maven-compiler-plugin</artifactId>
1686+
<configuration>
1687+
<!-- for some reason, setting maven.compiler.release property alone doesn't work -->
1688+
<release>${maven.compiler.release}</release>
1689+
</configuration>
1690+
</plugin>
1691+
</plugins>
1692+
</pluginManagement>
1693+
</build>
16771694
</profile>
16781695
<profile>
16791696
<id>coverage</id>

0 commit comments

Comments
 (0)