Skip to content

Update documentation in Lucene104PostingsWriter #15672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lyon-NEU wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update documentation in Lucene104PostingsWriter #15672

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc3deb
Update documentation in Lucene104PostingsWriter
Lyon-NEU Feb 6, 2026
363a5dc
Update CHANGES.txt
Lyon-NEU Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,8 @@ Other

* GITHUB#15619: Update documentation in Lucene104PostingsFormat. with 259 documents, the first 256 document ids should be encoded as one packed block (Lyon-NEU)

* GITHUB#15670: Update documentation in Lucene104PostingsWriter. since BLOCK_SIZE now is 256, level1 truely doc cnt equals 8192. (Lyon-NEU)
Copy link
Contributor

@msokolov msokolov Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we either remove this CHANGES entry or fix it?

Copy link
Contributor Author

@Lyon-NEU Lyon-NEU Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i have removed this changes entry


Build
---------------------
* Upgrade forbiddenapis to version 3.10. (Uwe Schindler)
Expand Down
2 changes: 1 addition & 1 deletion lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104PostingsWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ private void flushDocBlock(boolean finishTerm) throws IOException {
level0FreqNormAccumulator.clear();
}

if ((docCount & LEVEL1_MASK) == 0) { // true every 32 blocks (4,096 docs)
if ((docCount & LEVEL1_MASK) == 0) { // true every 32 blocks (8,192 docs)
Copy link
Contributor

@gaobinlong gaobinlong Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other similar comments need to be changed? Could we change them all at once?

Copy link
Contributor Author

@Lyon-NEU Lyon-NEU Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have just started reading the source code, so now I cannot find other comments that need to be changed. Maybe we could write BLOCK_SIZE*LEVEL1_NUM instead?

writeLevel1SkipData();
level1LastDocID = docID;
level1CompetitiveFreqNormAccumulator.clear();
Expand Down
Loading