Update documentation in Lucene104PostingsWriter#15672
Open
Lyon-NEU wants to merge 2 commits intoapache:mainfrom
Open
Update documentation in Lucene104PostingsWriter#15672Lyon-NEU wants to merge 2 commits intoapache:mainfrom
Lyon-NEU wants to merge 2 commits intoapache:mainfrom
Conversation
BLOCK_SIZE now is 256, lso, evel1 truely doc cnt equals 8192
msokolov
reviewed
Feb 20, 2026
lucene/CHANGES.txt
Outdated
|
|
||
| * GITHUB#15619: Update documentation in Lucene104PostingsFormat. with 259 documents, the first 256 document ids should be encoded as one packed block (Lyon-NEU) | ||
|
|
||
| * GITHUB#15670: Update documentation in Lucene104PostingsWriter. since BLOCK_SIZE now is 256, level1 truely doc cnt equals 8192. (Lyon-NEU) |
Contributor
There was a problem hiding this comment.
can we either remove this CHANGES entry or fix it?
Contributor
Author
There was a problem hiding this comment.
Sure, i have removed this changes entry
gaobinlong
reviewed
Mar 4, 2026
| } | ||
|
|
||
| if ((docCount & LEVEL1_MASK) == 0) { // true every 32 blocks (4,096 docs) | ||
| if ((docCount & LEVEL1_MASK) == 0) { // true every 32 blocks (8,192 docs) |
Contributor
There was a problem hiding this comment.
Are there any other similar comments need to be changed? Could we change them all at once?
Contributor
Author
There was a problem hiding this comment.
Hi, I have just started reading the source code, so now I cannot find other comments that need to be changed. Maybe we could write BLOCK_SIZE*LEVEL1_NUM instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLOCK_SIZE now is 256, lso, evel1 truely doc cnt equals 8192 (#15670)
Description