Skip to content

Change uses of withReadAdvice to use hints instead #14510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisHegarty merged 4 commits into from
May 9, 2025
Merged

Change uses of withReadAdvice to use hints instead #14510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
020aa4c
Remove ReadAdvice from IOContext
thecoop Apr 16, 2025
2113edf
Merge branch 'main' into read-advice-to-hints
thecoop May 2, 2025
62cb261
PR comments
thecoop May 6, 2025
4a1164f
These change behavior - revert
thecoop May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@
import org.apache.lucene.store.ByteArrayDataInput;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataInput;
import org.apache.lucene.store.FileDataHint;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BitUtil;
import org.apache.lucene.util.BytesRef;
Expand Down Expand Up @@ -149,9 +150,9 @@ public Lucene101PostingsReader(SegmentReadState state) throws IOException {
IndexFileNames.segmentFileName(
state.segmentInfo.name, state.segmentSuffix, Lucene101PostingsFormat.DOC_EXTENSION);
try {
// Postings have a forward-only access pattern, so pass ReadAdvice.NORMAL to perform
// readahead.
docIn = state.directory.openInput(docName, state.context.withReadAdvice(ReadAdvice.NORMAL));
docIn =
state.directory.openInput(
docName, state.context.withHints(FileTypeHint.DATA, FileDataHint.POSTINGS));
Copy link
Contributor

@jpountz jpountz May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this call also pass a DataAccessHint? The fact that it's sometimes provided and sometimes not is a bit confusing to me.

Copy link
Contributor Author

@thecoop thecoop May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't set a DataAccessHint as it's not RANDOM or SEQUENTIAL, just NORMAL.

I've tried to keep the initial hints as simple as possible here, without changing behaviour, so we can normalise and possibly modify behaviour in a subsequent PR

Copy link
Contributor

@jpountz jpountz May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh I had assumed until now that DataAccessHint.SEQUENTIAL effectively meant ReadAdvice.NORMAL.

Copy link
Contributor Author

@thecoop thecoop May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It maps onto ReadAdvice.SEQUENTIAL

Copy link

@bharath-techie bharath-techie Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thecoop @jpountz ,

This doesn't set a DataAccessHint as it's not RANDOM or SEQUENTIAL, just NORMAL.

#14635 - with this PR - we have removed the change in MMAPDirectory to apply read advice as normal. So if no data access hint is provided, it falls back to default read advice which is random. So read advice has changed from default to random ? Can you please confirm if I'm missing something and if not, then should we revert back the read advice to normal ?

Copy link
Contributor Author

@thecoop thecoop Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See reply in #14635 (comment)

CodecUtil.checkIndexHeader(
docIn, DOC_CODEC, version, version, state.segmentInfo.getId(), state.segmentSuffix);
CodecUtil.retrieveChecksum(docIn, expectedDocFileLength);
Expand Down
3 changes: 1 addition & 2 deletions ...rd-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/Lucene50CompoundReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.CollectionUtil;
import org.apache.lucene.util.IOUtils;

Expand Down Expand Up @@ -74,7 +73,7 @@ public Lucene50CompoundReader(Directory directory, SegmentInfo si) throws IOExce
}
expectedLength += CodecUtil.footerLength();

handle = directory.openInput(dataFileName, IOContext.DEFAULT.withReadAdvice(ReadAdvice.NORMAL));
handle = directory.openInput(dataFileName, IOContext.DEFAULT);
// DirectoryUtil.openInput(directory, dataFileName, context);
try {
CodecUtil.checkIndexHeader(
Expand Down
5 changes: 2 additions & 3 deletions ...va/org/apache/lucene/backward_codecs/lucene90/blocktree/Lucene90BlockTreeTermsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
import org.apache.lucene.internal.hppc.IntCursor;
import org.apache.lucene.internal.hppc.IntObjectHashMap;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.fst.ByteSequenceOutputs;
Expand Down Expand Up @@ -145,8 +145,7 @@ public Lucene90BlockTreeTermsReader(PostingsReaderBase postingsReader, SegmentRe

String indexName =
IndexFileNames.segmentFileName(segment, state.segmentSuffix, TERMS_INDEX_EXTENSION);
indexIn =
state.directory.openInput(indexName, state.context.withReadAdvice(ReadAdvice.NORMAL));
indexIn = state.directory.openInput(indexName, state.context.withHints(FileTypeHint.INDEX));
CodecUtil.checkIndexHeader(
indexIn,
TERMS_INDEX_CODEC_NAME,
Expand Down
9 changes: 5 additions & 4 deletions ...-codecs/src/java/org/apache/lucene/backward_codecs/lucene912/Lucene912PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@
import org.apache.lucene.store.ByteArrayDataInput;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataInput;
import org.apache.lucene.store.FileDataHint;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BitUtil;
import org.apache.lucene.util.BytesRef;
Expand Down Expand Up @@ -144,9 +145,9 @@ public Lucene912PostingsReader(SegmentReadState state) throws IOException {
IndexFileNames.segmentFileName(
state.segmentInfo.name, state.segmentSuffix, Lucene912PostingsFormat.DOC_EXTENSION);
try {
// Postings have a forward-only access pattern, so pass ReadAdvice.NORMAL to perform
// readahead.
docIn = state.directory.openInput(docName, state.context.withReadAdvice(ReadAdvice.NORMAL));
docIn =
state.directory.openInput(
docName, state.context.withHints(FileTypeHint.DATA, FileDataHint.POSTINGS));
CodecUtil.checkIndexHeader(
docIn, DOC_CODEC, version, version, state.segmentInfo.getId(), state.segmentSuffix);
CodecUtil.retrieveChecksum(docIn, expectedDocFileLength);
Expand Down
9 changes: 5 additions & 4 deletions ...rd-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@
import org.apache.lucene.index.SegmentReadState;
import org.apache.lucene.index.SlowImpactsEnum;
import org.apache.lucene.store.DataInput;
import org.apache.lucene.store.FileDataHint;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BitUtil;
import org.apache.lucene.util.BytesRef;
Expand Down Expand Up @@ -79,9 +80,9 @@ public Lucene99PostingsReader(SegmentReadState state) throws IOException {
IndexFileNames.segmentFileName(
state.segmentInfo.name, state.segmentSuffix, Lucene99PostingsFormat.DOC_EXTENSION);
try {
// Postings have a forward-only access pattern, so pass ReadAdvice.NORMAL to perform
// readahead.
docIn = state.directory.openInput(docName, state.context.withReadAdvice(ReadAdvice.NORMAL));
docIn =
state.directory.openInput(
docName, state.context.withHints(FileTypeHint.DATA, FileDataHint.POSTINGS));
version =
CodecUtil.checkIndexHeader(
docIn,
Expand Down
4 changes: 2 additions & 2 deletions lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
import org.apache.lucene.index.Terms;
import org.apache.lucene.index.TermsEnum;
import org.apache.lucene.store.ByteArrayDataInput;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.BytesRefBuilder;
Expand Down Expand Up @@ -75,7 +75,7 @@ public FSTTermsReader(SegmentReadState state, PostingsReaderBase postingsReader)

this.postingsReader = postingsReader;
this.fstTermsInput =
state.directory.openInput(termsFileName, state.context.withReadAdvice(ReadAdvice.NORMAL));
state.directory.openInput(termsFileName, state.context.withHints(FileTypeHint.INDEX));

IndexInput in = this.fstTermsInput;

Expand Down
5 changes: 2 additions & 3 deletions lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextCompoundFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
import org.apache.lucene.index.IndexFileNames;
import org.apache.lucene.index.SegmentInfo;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.IndexOutput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.BytesRefBuilder;
import org.apache.lucene.util.StringHelper;
Expand All @@ -55,8 +55,7 @@ public SimpleTextCompoundFormat() {}
@Override
public CompoundDirectory getCompoundReader(Directory dir, SegmentInfo si) throws IOException {
String dataFile = IndexFileNames.segmentFileName(si.name, "", DATA_EXTENSION);
final IndexInput in =
dir.openInput(dataFile, IOContext.DEFAULT.withReadAdvice(ReadAdvice.NORMAL));
final IndexInput in = dir.openInput(dataFile, IOContext.DEFAULT.withHints(FileTypeHint.DATA));

BytesRefBuilder scratch = new BytesRefBuilder();

Expand Down
7 changes: 5 additions & 2 deletions ...re/src/java/org/apache/lucene/codecs/lucene102/Lucene102BinaryQuantizedVectorsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@
import org.apache.lucene.search.KnnCollector;
import org.apache.lucene.search.VectorScorer;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataAccessHint;
import org.apache.lucene.store.FileDataHint;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.Bits;
import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.RamUsageEstimator;
Expand Down Expand Up @@ -102,7 +104,8 @@ class Lucene102BinaryQuantizedVectorsReader extends FlatVectorsReader {
Lucene102BinaryQuantizedVectorsFormat.VECTOR_DATA_CODEC_NAME,
// Quantized vectors are accessed randomly from their node ID stored in the HNSW
// graph.
state.context.withReadAdvice(ReadAdvice.RANDOM));
state.context.withHints(
FileTypeHint.DATA, FileDataHint.KNN_VECTORS, DataAccessHint.RANDOM));
success = true;
} finally {
if (success == false) {
Expand Down
9 changes: 5 additions & 4 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@
import org.apache.lucene.store.ByteArrayDataInput;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataInput;
import org.apache.lucene.store.FileDataHint;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BitUtil;
import org.apache.lucene.util.BytesRef;
Expand Down Expand Up @@ -152,9 +153,9 @@ public Lucene103PostingsReader(SegmentReadState state) throws IOException {
IndexFileNames.segmentFileName(
state.segmentInfo.name, state.segmentSuffix, Lucene103PostingsFormat.DOC_EXTENSION);
try {
// Postings have a forward-only access pattern, so pass ReadAdvice.NORMAL to perform
// readahead.
docIn = state.directory.openInput(docName, state.context.withReadAdvice(ReadAdvice.NORMAL));
docIn =
state.directory.openInput(
docName, state.context.withHints(FileTypeHint.DATA, FileDataHint.POSTINGS));
CodecUtil.checkIndexHeader(
docIn, DOC_CODEC, version, version, state.segmentInfo.getId(), state.segmentSuffix);
CodecUtil.retrieveChecksum(docIn, expectedDocFileLength);
Expand Down
5 changes: 2 additions & 3 deletions .../src/java/org/apache/lucene/codecs/lucene103/blocktree/Lucene103BlockTreeTermsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
import org.apache.lucene.internal.hppc.IntCursor;
import org.apache.lucene.internal.hppc.IntObjectHashMap;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.IOUtils;

Expand Down Expand Up @@ -126,8 +126,7 @@ public Lucene103BlockTreeTermsReader(PostingsReaderBase postingsReader, SegmentR

String indexName =
IndexFileNames.segmentFileName(segment, state.segmentSuffix, TERMS_INDEX_EXTENSION);
indexIn =
state.directory.openInput(indexName, state.context.withReadAdvice(ReadAdvice.NORMAL));
indexIn = state.directory.openInput(indexName, state.context.withHints(FileTypeHint.INDEX));
CodecUtil.checkIndexHeader(
indexIn,
TERMS_INDEX_CODEC_NAME,
Expand Down
3 changes: 1 addition & 2 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90CompoundReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.CollectionUtil;
import org.apache.lucene.util.IOUtils;

Expand Down Expand Up @@ -75,7 +74,7 @@ public Lucene90CompoundReader(Directory directory, SegmentInfo si) throws IOExce
.orElseGet(() -> CodecUtil.indexHeaderLength(Lucene90CompoundFormat.DATA_CODEC, ""))
+ CodecUtil.footerLength();

handle = directory.openInput(dataFileName, IOContext.DEFAULT.withReadAdvice(ReadAdvice.NORMAL));
handle = directory.openInput(dataFileName, IOContext.DEFAULT);
try {
CodecUtil.checkIndexHeader(
handle, Lucene90CompoundFormat.DATA_CODEC, version, version, si.getId(), "");
Expand Down
8 changes: 3 additions & 5 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
import org.apache.lucene.store.ByteArrayDataInput;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataInput;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.RandomAccessInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.FixedBitSet;
import org.apache.lucene.util.IOUtils;
Expand Down Expand Up @@ -114,10 +114,8 @@ final class Lucene90DocValuesProducer extends DocValuesProducer {

String dataName =
IndexFileNames.segmentFileName(state.segmentInfo.name, state.segmentSuffix, dataExtension);
// Doc-values have a forward-only access pattern, so pass ReadAdvice.NORMAL to perform
// readahead.
this.data =
state.directory.openInput(dataName, state.context.withReadAdvice(ReadAdvice.NORMAL));
// Doc-values have a forward-only access pattern
this.data = state.directory.openInput(dataName, state.context.withHints(FileTypeHint.DATA));
boolean success = false;
try {
final int version2 =
Expand Down
6 changes: 3 additions & 3 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90NormsProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@
import org.apache.lucene.index.SegmentReadState;
import org.apache.lucene.internal.hppc.IntObjectHashMap;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.RandomAccessInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.IOUtils;

/** Reader for {@link Lucene90NormsFormat} */
Expand Down Expand Up @@ -81,8 +81,8 @@ final class Lucene90NormsProducer extends NormsProducer implements Cloneable {

String dataName =
IndexFileNames.segmentFileName(state.segmentInfo.name, state.segmentSuffix, dataExtension);
// Norms have a forward-only access pattern, so pass ReadAdvice.NORMAL to perform readahead.
data = state.directory.openInput(dataName, state.context.withReadAdvice(ReadAdvice.NORMAL));
// Norms have a forward-only access pattern
data = state.directory.openInput(dataName, state.context.withHints(FileTypeHint.DATA));
boolean success = false;
try {
final int version2 =
Expand Down
7 changes: 4 additions & 3 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90PointsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
import org.apache.lucene.index.SegmentReadState;
import org.apache.lucene.internal.hppc.IntObjectHashMap;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.bkd.BKDReader;

Expand Down Expand Up @@ -61,7 +61,7 @@ public Lucene90PointsReader(SegmentReadState readState) throws IOException {
try {
indexIn =
readState.directory.openInput(
indexFileName, readState.context.withReadAdvice(ReadAdvice.NORMAL));
indexFileName, readState.context.withHints(FileTypeHint.INDEX));
CodecUtil.checkIndexHeader(
indexIn,
Lucene90PointsFormat.INDEX_CODEC_NAME,
Expand All @@ -72,9 +72,10 @@ public Lucene90PointsReader(SegmentReadState readState) throws IOException {
CodecUtil.retrieveChecksum(indexIn);

// Points read whole ranges of bytes at once, so pass ReadAdvice.NORMAL to perform readahead.
// DATA
dataIn =
readState.directory.openInput(
dataFileName, readState.context.withReadAdvice(ReadAdvice.NORMAL));
dataFileName, readState.context.withHints(FileTypeHint.DATA));
CodecUtil.checkIndexHeader(
dataIn,
Lucene90PointsFormat.DATA_CODEC_NAME,
Expand Down
4 changes: 2 additions & 2 deletions lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/FieldsIndexReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
import org.apache.lucene.codecs.CodecUtil;
import org.apache.lucene.index.IndexFileNames;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.RandomAccessInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.packed.DirectMonotonicReader;

final class FieldsIndexReader extends FieldsIndex {
Expand Down Expand Up @@ -69,7 +69,7 @@ final class FieldsIndexReader extends FieldsIndex {
indexInput =
dir.openInput(
IndexFileNames.segmentFileName(name, suffix, extension),
context.withReadAdvice(ReadAdvice.NORMAL));
context.withHints(FileTypeHint.INDEX));
boolean success = false;
try {
CodecUtil.checkIndexHeader(
Expand Down
6 changes: 4 additions & 2 deletions .../org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,12 @@
import org.apache.lucene.store.AlreadyClosedException;
import org.apache.lucene.store.ByteArrayDataInput;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataAccessHint;
import org.apache.lucene.store.DataInput;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BitUtil;
import org.apache.lucene.util.BytesRef;
Expand Down Expand Up @@ -141,7 +142,8 @@ public Lucene90CompressingStoredFieldsReader(
ChecksumIndexInput metaIn = null;
try {
// Open the data file
fieldsStream = d.openInput(fieldsStreamFN, context.withReadAdvice(ReadAdvice.RANDOM));
fieldsStream =
d.openInput(fieldsStreamFN, context.withHints(FileTypeHint.DATA, DataAccessHint.RANDOM));
version =
CodecUtil.checkIndexHeader(
fieldsStream, formatName, VERSION_START, VERSION_CURRENT, si.getId(), segmentSuffix);
Expand Down
10 changes: 8 additions & 2 deletions ...a/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@
import org.apache.lucene.store.ByteBuffersDataInput;
import org.apache.lucene.store.ByteBuffersDataOutput;
import org.apache.lucene.store.ChecksumIndexInput;
import org.apache.lucene.store.DataAccessHint;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.FileDataHint;
import org.apache.lucene.store.FileTypeHint;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.store.IndexInput;
import org.apache.lucene.store.RandomAccessInput;
import org.apache.lucene.store.ReadAdvice;
import org.apache.lucene.util.ArrayUtil;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.IOUtils;
Expand Down Expand Up @@ -146,7 +148,11 @@ public Lucene90CompressingTermVectorsReader(
// Open the data file
final String vectorsStreamFN =
IndexFileNames.segmentFileName(segment, segmentSuffix, VECTORS_EXTENSION);
vectorsStream = d.openInput(vectorsStreamFN, context.withReadAdvice(ReadAdvice.RANDOM));
vectorsStream =
d.openInput(
vectorsStreamFN,
context.withHints(
FileTypeHint.DATA, FileDataHint.KNN_VECTORS, DataAccessHint.RANDOM));
version =
CodecUtil.checkIndexHeader(
vectorsStream, formatName, VERSION_START, VERSION_CURRENT, si.getId(), segmentSuffix);
Expand Down
Loading