Skip to content

Add BIT support to BITPOS #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 20, 2024
Merged

Add BIT support to BITPOS #2170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
815d11f
Add bit support to BITPOS
sheharyaar Mar 14, 2024
f0f7dbb
Fix bitmap logic and add test cases
sheharyaar Mar 15, 2024
5b86fff
Add lamda for bit range query
sheharyaar Mar 16, 2024
980c174
Merge branch 'unstable' into feat-bitpos-bit
jihuayu Mar 16, 2024
d64ec7b
Fix clang format
sheharyaar Mar 16, 2024
7ca036e
Fix CI and fix RawBitpos
sheharyaar Mar 17, 2024
a93d2af
Fix golangci-lint
sheharyaar Mar 17, 2024
d1a0285
Merge branch 'unstable' into feat-bitpos-bit
jihuayu Mar 18, 2024
039e5b9
Improve lamda function
sheharyaar Mar 18, 2024
59662aa
Merge branch 'unstable' into feat-bitpos-bit
jihuayu Mar 18, 2024
1f036d6
Fix review suggestions
sheharyaar Mar 18, 2024
4cd8aba
Merge branch 'unstable' into feat-bitpos-bit
sheharyaar Mar 19, 2024
80cef97
Merge branch 'unstable' into feat-bitpos-bit
mapleFU Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/status.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) < sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new std::string(*std::move(v))) {} // NOLINT
template <typename U, typename std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
: BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
: BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}

StringInStatusOr(const StringInStatusOr& v) = delete;

Expand Down
2 changes: 1 addition & 1 deletion tests/cppunit/types/bitmap_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ TEST_P(RedisBitmapTest, BitPosStopGiven) {
}
bitmap_->BitPos(key_, false, 0, 0, /*stop_given=*/true, &pos, /*bit_index=*/false);
EXPECT_EQ(-1, pos);
bitmap_->BitPos(key_, false, 0, 1, /*stop_given=*/false, &pos, /*bit_index=*/ false);
bitmap_->BitPos(key_, false, 0, 1, /*stop_given=*/false, &pos, /*bit_index=*/false);
EXPECT_EQ(9, pos);

auto s = bitmap_->Del(key_);
Expand Down