Add BIT support to BITPOS #2170
Conversation
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
|
For review questions, please refer : #1212 (comment) |
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
|
This general LGTM. I'm suffering from working overtime today, so I'll take a carefully look tomorrow |
|
@mapleFU, there is an issue that needs to be discussed : #1212 (comment) Please take a look at it when your free. |
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
jihuayu
left a comment
jihuayu
left a comment
There was a problem hiding this comment.
So careful test case. Thank you!
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
| } | ||
|
|
||
| *pos = util::msb::RawBitpos(reinterpret_cast<const uint8_t *>(string_value.data()) + byte_start, bytes_cnt, bit); | ||
|
|
There was a problem hiding this comment.
Should we check byte_stop here?
There was a problem hiding this comment.
Oh, my bad, it handle the case in is_bit_index
|
Rest LGTM, this part of logic is too tricky, thanks a lot for efforts |
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
|
@sheharyaar Would you mind resolve conflict? I edit the |
|
Will merge it tonight if no negative comments |
|
|
Merged, thanks! |
3 participants
This pull requests adds BIT support to BITPOS.
Fixes : #1212