Skip to content

optimize: binary packaging directory structure#7388

Merged
funky-eyes merged 6 commits intoapache:2.xfrom
OmCheeLin:optimize/dir-structure
Jun 6, 2025
Merged

optimize: binary packaging directory structure#7388
funky-eyes merged 6 commits intoapache:2.xfrom
OmCheeLin:optimize/dir-structure

Conversation

@OmCheeLin
Copy link
Contributor

@OmCheeLin OmCheeLin commented May 30, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7368.

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

run commmand
mvn -Prelease-seata -Dmaven.test.skip=true -Dskip.npm=true -T4C -Dpmd.skip=true clean install -U
zip file:
image
tar.gz file:
image

Ⅴ. Special notes for reviews

code has too few changes, still need to register the PR changes?

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.84%. Comparing base (f46065c) to head (b1e63c8).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x    #7388   +/-   ##
=========================================
  Coverage     58.84%   58.84%           
- Complexity      531      535    +4     
=========================================
  Files          1280     1280           
  Lines         46066    46066           
  Branches       5557     5557           
=========================================
  Hits          27108    27108           
- Misses        16381    16384    +3     
+ Partials       2577     2574    -3     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly
Copy link
Member

slievrly commented Jun 2, 2025

@OmCheeLin Good work. However, we need to wait until the previous UT issues are fixed before reviewing.

@slievrly slievrly added this to the 2.5.0 milestone Jun 2, 2025
@slievrly
Copy link
Member

slievrly commented Jun 3, 2025

@funky-eyes
Copy link
Contributor

Please send your DingTalk ID to jianbin@apache.org, and I will invite you to join the Seata developers group.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes requested a review from Copilot June 4, 2025 12:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the binary packaging directory structure for the Seata release distribution.

  • Updated the release assembly configuration in distribution/release-seata.xml to include a base directory for the packaged binaries.
  • Updated the changelog files (both zh-cn and en-us) to reflect the new packaging structure.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
distribution/release-seata.xml Updated assembly configuration: enabled base directory inclusion and set a new baseDirectory name
changes/zh-cn/2.x.md, changes/en-us/2.x.md Changelog entries added for the packaging structure optimization
Comments suppressed due to low confidence (1)

distribution/release-seata.xml:22

  • Changing 'includeBaseDirectory' from false to true along with specifying a new 'baseDirectory' updates the binary packaging structure. Please verify that any dependent deployment scripts or tooling expecting the previous structure are updated accordingly.
    <includeBaseDirectory>true</includeBaseDirectory>

@funky-eyes funky-eyes merged commit 09d30ca into apache:2.x Jun 6, 2025
9 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize the binary packaging directory structure

4 participants