Not closed FileInputStream Object caused "To many open files" IOException #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use IOException "To many open files". Write better message in case of IOExcepion
Contributor
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
1 similar comment
Contributor
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
Contributor
|
Your commit is correct, thanks a lot for it. Please just fix code identation before I merge it. |
Contributor
|
@mariofusco When you're merging, can you please merge to 6.5.x as well? |
code indentation fixed
fixed code indentation apache#2
Contributor
Author
|
We are using 6.3.0-Final. It would be nice if you can merge into 6.3.x branch as well. |
mariofusco
pushed a commit
that referenced
this pull request
Aug 11, 2016
…tion (#865) * close FileInputStream at the end. Not to closing in some cases can cause IOException "To many open files". Write better message in case of IOExcepion * Update FileKieModule.java code indentation fixed * Update FileKieModule.java fixed code indentation #2 (cherry picked from commit 1615518)
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
This PR is corollary of a selenium test migration effort. For more details see: https://issues.jboss.org/browse/BAQE-381
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our case, this part caused endless loop(blocking system resources) in the jenkins build process(tests execution) and was returning incorrect error message. The getBytes method was not closing FileInputStream at the end of reading files and caused IOException "To many open files".