Skip to content

Not closed FileInputStream Object caused "To many open files" IOException #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2016
Merged

Not closed FileInputStream Object caused "To many open files" IOException #865

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cd615
close FileInputStream at the end. Not to closing in some cases can ca…
Aug 5, 2016
d12814d
Update FileKieModule.java
sisivy Aug 5, 2016
0e56464
Update FileKieModule.java
sisivy Aug 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions drools-compiler/src/main/java/org/drools/compiler/kie/builder/impl/FileKieModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,26 @@ public boolean isAvailable(String pResourceName) {


@Override
public byte[] getBytes(String pResourceName) {
public byte[] getBytes(String pResourceName ) {
FileInputStream input = null;
try {
File resource = new File( file, pResourceName);
if( resource.exists() ) {
return IoUtils.readBytesFromInputStream( new FileInputStream( resource ) );
input = new FileInputStream( resource );
return IoUtils.readBytesFromInputStream( input );
} else {
return null;
}
} catch ( Exception e ) {
throw new RuntimeException("Unable to get bytes for: " + new File( file, pResourceName) );
} catch ( IOException e ) {
throw new RuntimeException("Unable to get bytes for: " + new File( file, pResourceName) + " " +e.getMessage());
} finally {
if( input != null ){
try {
input.close();
} catch ( IOException e ) {
e.printStackTrace();
}
}
}
}

Expand Down