AWS: Skip cleanup of analytics accelerator when disabled #13134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an S3AsyncClient has been used from S3FileIO and the analytics accelerator is disabled (is disabled by default), the S3FileIO may throw an exception during closing if the analytics accelerator is not on the classpath. Closes apache#13133
malhotrashivam
approved these changes
May 23, 2025
Contributor
|
@SanjayMarreddi since you were working on #12299 can you please double-check this change here? |
SanjayMarreddi
approved these changes
May 23, 2025
Contributor
SanjayMarreddi
left a comment
SanjayMarreddi
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for this fix.
Contributor
|
Also want to highlight the relevant clean up PR similar to this change here: #12891 |
nastra
approved these changes
May 23, 2025
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
If an S3AsyncClient has been used from S3FileIO and the analytics accelerator is disabled (is disabled by default), the S3FileIO may throw an exception during closing if the analytics accelerator is not on the classpath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an S3AsyncClient has been used from S3FileIO and the analytics accelerator is disabled (is disabled by default), the S3FileIO may throw an exception during closing if the analytics accelerator is not on the classpath.
Closes #13133