AWS: Close the S3SeekableInputStreamFactory before removing from cache #12891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajdchak
reviewed
Apr 24, 2025
aws/src/main/java/org/apache/iceberg/aws/s3/AnalyticsAcceleratorUtil.java
Show resolved
Hide resolved
rajdchak
suggested changes
Apr 24, 2025
rajdchak
left a comment
rajdchak
left a comment
There was a problem hiding this comment.
Before invalidating the factories from the cache also we should close the factories.
rajdchak
approved these changes
Apr 25, 2025
stubz151
approved these changes
Apr 25, 2025
Contributor
Author
|
@HonahX @kevinjqliu May I request for a review on this PR please? |
nastra
reviewed
May 23, 2025
| return new S3SeekableInputStreamFactory(objectClient, streamConfiguration); | ||
| } | ||
|
|
||
| private static void handleRemoval(S3SeekableInputStreamFactory factory) { |
Contributor
There was a problem hiding this comment.
this can probably just be inlined, otherwise the naming of the method is a bit misleading, because we're not handling removal inside the method but closing the factory. Alternatively just rename the method to close(..)
Contributor
Author
There was a problem hiding this comment.
Agree, I'll update it to close then.
SanjayMarreddi
force-pushed
the
close-input-stream-factory
branch
from
074bf77 to
ee79314
Compare
nastra
approved these changes
May 23, 2025
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current integration with the S3 Analytics Accelerator Library ( #12299 ) is not closing the
S3SeekableInputStreamFactoryonS3FileIOclose. This PR incorporates that logic by closing it before removing from cache.