Skip to content

[ADDENDUM] HBASE-29689 Ignore JSON files in RAT check #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PDavid merged 2 commits into from
Dec 4, 2025
Merged

[ADDENDUM] HBASE-29689 Ignore JSON files in RAT check #7507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc6990
HBASE-29689 [ADDENDUM] Ignore JSON files in RAT check
PDavid Dec 3, 2025
1e57af7
HBASE-29689 [ADDENDUM] Exclude node_modules from spotless check
PDavid Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2140,6 +2140,8 @@
<exclude>**/vote.tmpl</exclude>
<!-- gzipped list of S3N URIs for hbase-it -->
<exclude>**/CC-MAIN-2021-10-warc.paths.gz</exclude>
<!-- Cannot add ASF licence to JSON files as JSON files cannot have comments in them. -->
<exclude>**/*.json</exclude>
</excludes>
</configuration>
</plugin>
Expand Down Expand Up @@ -3275,6 +3277,7 @@
<exclude>**/target/**</exclude>
<exclude>**/dependency-reduced-pom.xml</exclude>
<exclude>**/.idea/**</exclude>
<exclude>**/node_modules/**</exclude>
Copy link
Contributor

@Apache9 Apache9 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are under the node_modules directory?

Copy link
Contributor

@Apache9 Apache9 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so this is not in our code base, we just pull this down when building web site?

Copy link
Contributor Author

@PDavid PDavid Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the new hbase-website submodule for the new website. Since this project uses Node.js as a build tool a node_modules directory is created and the dependencies (Node.js / npm packages) of the new website are downloaded and placed.

The spotless check failed because of formatting violations in files under hbase-website/node_modules. Since this contains libraries, I guess we don't want to check them for formatting.

Copy link
Contributor Author

@PDavid PDavid Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also have the exclude more specifically for hbase-website/node_modules, I just thought a node_modules directory - anywhere it is - should not be checked by spotless.

Copy link
Contributor Author

@PDavid PDavid Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so this is not in our code base, we just pull this down when building web site?

Exactly.

</excludes>
<!-- define the steps to apply to those files -->
<trimTrailingWhitespace/>
Expand Down Expand Up @@ -3306,6 +3309,7 @@
<exclude>src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCOutputFormat.java</exclude>
<exclude>src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCRecord.java</exclude>
<exclude>src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCWritable.java</exclude>
<exclude>**/node_modules/**</exclude>
</excludes>
<licenseHeader>
<file>${session.executionRootDirectory}/dev-support/license-header</file>
Expand Down