[ADDENDUM] HBASE-29689 Ignore JSON files in RAT check #7507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAT check complained that JSON files (under hbase-website) does not have ASF license which is true. But JSON files cannot have comments in them so we cannot add the ASF licence there. So we exclude JSON files from RAT check.
Contributor
Author
|
After this change, executing |
Contributor
|
Thanks for that! |
This comment has been minimized.
This comment has been minimized.
The spotless check failed because of formatting violations in files under hbase-website/node_modules. Since this contains node packages (libraries) we don't want to check them for formatting.
Apache9
reviewed
Dec 4, 2025
| <exclude>**/target/**</exclude> | ||
| <exclude>**/dependency-reduced-pom.xml</exclude> | ||
| <exclude>**/.idea/**</exclude> | ||
| <exclude>**/node_modules/**</exclude> |
Contributor
There was a problem hiding this comment.
What are under the node_modules directory?
Contributor
There was a problem hiding this comment.
OK, so this is not in our code base, we just pull this down when building web site?
Contributor
Author
There was a problem hiding this comment.
We have the new hbase-website submodule for the new website. Since this project uses Node.js as a build tool a node_modules directory is created and the dependencies (Node.js / npm packages) of the new website are downloaded and placed.
The spotless check failed because of formatting violations in files under hbase-website/node_modules. Since this contains libraries, I guess we don't want to check them for formatting.
Contributor
Author
There was a problem hiding this comment.
We can also have the exclude more specifically for hbase-website/node_modules, I just thought a node_modules directory - anywhere it is - should not be checked by spotless.
Contributor
Author
There was a problem hiding this comment.
OK, so this is not in our code base, we just pull this down when building web site?
Exactly.
|
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
Dec 4, 2025
liuxiaocs7
approved these changes
Dec 4, 2025
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
|
petersomogyi
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore JSON files in RAT check
When I run
mvn clean install -DskipTests -Prelease -Drat.skip=false && mvn install -DskipTests site assembly:single -Prelease -Drat.skip=falseRAT check complained that JSON files (under hbase-website) does not have ASF license which is true. But JSON files cannot have comments in them so we cannot add the ASF licence there.So we exclude JSON files from RAT check.
Exclude node_modules from spotless check
The spotless check failed because of formatting violations in files under hbase-website/node_modules. Since this contains node packages (libraries) we don't want to check them for formatting.