Skip to content

HBASE-29629 Record the quota user name value on metrics for RpcThrottlingExceptions #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchevreuil merged 2 commits into from
Sep 30, 2025
Merged

HBASE-29629 Record the quota user name value on metrics for RpcThrottlingExceptions #7345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b7d2d4
Support name override
Sep 25, 2025
2d7406c
empty commit to rerun flaky test
Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ protected boolean isExceedThrottleQuotaEnabled() {
* username
* @param ugi The request's UserGroupInformation
*/
private String getQuotaUserName(final UserGroupInformation ugi) {
String getQuotaUserName(final UserGroupInformation ugi) {
if (userOverrideRequestAttributeKey == null) {
return ugi.getShortUserName();
}
Expand Down
4 changes: 2 additions & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionServerRpcQuotaManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public OperationQuota checkScanQuota(final Region region,
LOG.debug("Throttling exception for user=" + ugi.getUserName() + " table=" + table + " scan="
+ scanRequest.getScannerId() + ": " + e.getMessage());

rsServices.getMetrics().recordThrottleException(e.getType(), ugi.getShortUserName(),
rsServices.getMetrics().recordThrottleException(e.getType(), quotaCache.getQuotaUserName(ugi),
table.getNameAsString());

throw e;
Expand Down Expand Up @@ -276,7 +276,7 @@ public OperationQuota checkBatchQuota(final Region region, final int numWrites,
LOG.debug("Throttling exception for user=" + ugi.getUserName() + " table=" + table
+ " numWrites=" + numWrites + " numReads=" + numReads + ": " + e.getMessage());

rsServices.getMetrics().recordThrottleException(e.getType(), ugi.getShortUserName(),
rsServices.getMetrics().recordThrottleException(e.getType(), quotaCache.getQuotaUserName(ugi),
table.getNameAsString());

throw e;
Expand Down