-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29629 Record the quota user name value on metrics for RpcThrottlingExceptions #7345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's put a more accurate description, something like:
"Record the proper user name value on metrics for quotas exception throttling"
Sure, I've updated the title. Thanks for the review! |
…lingExceptions (#7345) Signed-off-by: Wellington Chevreuil <[email protected]>
…lingExceptions (#7345) Signed-off-by: Wellington Chevreuil <[email protected]>
…lingExceptions (#7345) Signed-off-by: Wellington Chevreuil <[email protected]>
…ics for RpcThrottlingExceptions (apache#7345) Signed-off-by: Wellington Chevreuil <[email protected]>
…ics for RpcThrottlingExceptions (apache#7345) (#208) Signed-off-by: Wellington Chevreuil <[email protected]>
…ics for RpcThrottlingExceptions (apache#7345) (#208) Signed-off-by: Wellington Chevreuil <[email protected]>
Although the quota system checks for overrides in the rpc calls, the metrics produced for throttling only show the ugi shortName and not the quotaUserName which is actually used to check the quota. This PR modifies the throttles to produce the appropriate name.