Skip to content

Conversation

@sidkhillon
Copy link
Contributor

Although the quota system checks for overrides in the rpc calls, the metrics produced for throttling only show the ugi shortName and not the quotaUserName which is actually used to check the quota. This PR modifies the throttles to produce the appropriate name.

@sidkhillon
Copy link
Contributor Author

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 7s master passed
+1 💚 compile 3m 22s master passed
+1 💚 checkstyle 0m 37s master passed
+1 💚 spotbugs 1m 33s master passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 12s the patch passed
+1 💚 compile 3m 22s the patch passed
+1 💚 javac 3m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 37s the patch passed
+1 💚 spotbugs 1m 41s the patch passed
+1 💚 hadoopcheck 12m 2s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
39m 25s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7345/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7345
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 377d0d9418db 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2d7406c
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7345/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 24s master passed
+1 💚 compile 0m 59s master passed
+1 💚 javadoc 0m 28s master passed
+1 💚 shadedjars 6m 14s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 javadoc 0m 27s the patch passed
+1 💚 shadedjars 6m 13s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 210m 23s hbase-server in the patch passed.
237m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7345/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7345
Optional Tests javac javadoc unit compile shadedjars
uname Linux 6a80e4191f4c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 2d7406c
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7345/2/testReport/
Max. process+thread count 4189 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7345/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's put a more accurate description, something like:

"Record the proper user name value on metrics for quotas exception throttling"

@sidkhillon sidkhillon changed the title HBASE-29629 RpcThrottlingException Metrics do not handle name overrides HBASE-29629 Record the quota user name value on metrics for RpcThrottlingExceptions Sep 26, 2025
@sidkhillon
Copy link
Contributor Author

LGTM, but let's put a more accurate description, something like:

"Record the proper user name value on metrics for quotas exception throttling"

Sure, I've updated the title. Thanks for the review!

@wchevreuil wchevreuil merged commit 2c3b89b into apache:master Sep 30, 2025
1 check passed
wchevreuil pushed a commit that referenced this pull request Sep 30, 2025
wchevreuil pushed a commit that referenced this pull request Sep 30, 2025
wchevreuil pushed a commit that referenced this pull request Sep 30, 2025
sidkhillon added a commit to HubSpot/hbase that referenced this pull request Sep 30, 2025
…ics for RpcThrottlingExceptions (apache#7345)

Signed-off-by: Wellington Chevreuil <[email protected]>
sidkhillon added a commit to HubSpot/hbase that referenced this pull request Oct 8, 2025
…ics for RpcThrottlingExceptions (apache#7345) (#208)

Signed-off-by: Wellington Chevreuil <[email protected]>
charlesconnell pushed a commit to HubSpot/hbase that referenced this pull request Oct 22, 2025
…ics for RpcThrottlingExceptions (apache#7345) (#208)

Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants