HBASE-27802 Manage static javascript resources programatically #7033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#6864) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 2f9d9fc)
…dum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap.
Contributor
Author
|
This is a backport of #6864 to I cherry-picked the master commit and resolved the conflicts. The reason this patch was not applying clearly is that on master we have the website and the reference guide (asciidoc) building code but on other branches we don't. I tested this backported patch the same way as I described here: #6864 (comment) |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
One replication-related test failed with timeout in the PR build but I think that is unrelated. |
Contributor
|
Hi @PDavid Should I merge this and related PRs? |
Contributor
Author
Hi @NihalJain, |
Member
|
Ah. Thanks @NihalJain ! |
mokai87
pushed a commit
to mokai87/hbase
that referenced
this pull request
Aug 7, 2025
…e#7033) * HBASE-27802 Manage static javascript resources programatically (apache#6864) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 2f9d9fc) * HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap. --------- Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Nihal Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is
Currently, the static JavaScript, CSS resources need to be manually managed. That is, if any of these has to be updated, we will be required to download them from web and place them under the appropriate path. This can be cumbersome.
After
To be able to manage them with minimal manual effort we could manage them as part of build.
Approach
This solution is very similar to how we manage the websitestatic resources in our build: #6668
Download and extract the UI resources as webjars using the
maven-dependency-pluginin our build. It will only copy the required files to thehbase-server/target/hbase-webapps/staticdirectory.The REST and Thrift projects copies the static JavaScript, CSS resources from hbase-server - as before.
This way the no new dependency is packaged into the application, only the required JS, CSS files are copied and packaged.
Upgrading in the future
From now on upgrading the static JavaScript, CSS resources means to:
pom.xml.Upgrades
Also upgraded the following static resources to current latest version: