Skip to content

Commit 8932be8

Browse files
PDavidmokai87
PDavid
authored and
mokai87
committed
HBASE-27802 Manage static javascript resources programatically (apache#7033)
* HBASE-27802 Manage static javascript resources programatically (apache#6864) Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 2f9d9fc) * HBASE-27802 Manage static javascript resources programatically (addendum: Fix not working popovers on UI) Popovers were not working on the UI and the following JS error was logged to browser console: ``` Uncaught TypeError: i.createPopper is not a function ``` This is because popper.js was not available on the page for Bootstrap. Solution: We use bootstrap.bundle.min.js instead which includes both popper.js and Bootstrap. --------- Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Nihal Jain <[email protected]>
1 parent ebbfaf4 commit 8932be8

File tree

20 files changed

+126
-48
lines changed

20 files changed

+126
-48
lines changed

‎hbase-rest/pom.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@
280280
<skipAssembly>true</skipAssembly>
281281
</configuration>
282282
</plugin>
283-
<!-- Copy the static web resources (JS, CSS, images, etc.) from hbase-server sources -->
283+
<!-- Copy the static web resources (JS, CSS, images, etc.) from hbase-server -->
284284
<plugin>
285285
<artifactId>maven-resources-plugin</artifactId>
286286
<executions>
@@ -296,7 +296,7 @@
296296
<overwrite>true</overwrite>
297297
<resources>
298298
<resource>
299-
<directory>../hbase-server/src/main/resources/hbase-webapps/static</directory>
299+
<directory>../hbase-server/target/hbase-webapps/static</directory>
300300
</resource>
301301
</resources>
302302
</configuration>

‎hbase-rest/src/main/resources/hbase-webapps/rest/footer.jsp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
--%>
2020

2121
<script src="/static/js/jquery.min.js" type="text/javascript"></script>
22-
<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
22+
<script src="/static/js/bootstrap.bundle.min.js" type="text/javascript"></script>
2323
<script src="/static/js/tab.js" type="text/javascript"></script>
2424
<script type="text/javascript">
2525
$(document).ready(function() {

‎hbase-server/pom.xml‎

Lines changed: 104 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,9 @@
893893
<build>
894894
<plugins>
895895
<plugin>
896+
<groupId>org.apache.maven.plugins</groupId>
896897
<artifactId>maven-dependency-plugin</artifactId>
898+
<version>${maven.dependency.version}</version>
897899
<executions>
898900
<execution>
899901
<id>create-mrapp-generated-classpath</id>
@@ -909,6 +911,108 @@
909911
<outputFile>${project.build.directory}/test-classes/mrapp-generated-classpath</outputFile>
910912
</configuration>
911913
</execution>
914+
<execution>
915+
<id>unpack-ui-resources-js</id>
916+
<goals>
917+
<goal>unpack</goal>
918+
</goals>
919+
<phase>process-resources</phase>
920+
<configuration>
921+
<artifactItems>
922+
<artifactItem>
923+
<groupId>org.webjars</groupId>
924+
<artifactId>bootstrap</artifactId>
925+
<version>${bootstrap.version}</version>
926+
<type>jar</type>
927+
<overWrite>true</overWrite>
928+
<includes>**/js/bootstrap.bundle.min.js</includes>
929+
<fileMappers>
930+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
931+
</fileMappers>
932+
</artifactItem>
933+
<artifactItem>
934+
<groupId>org.webjars</groupId>
935+
<artifactId>jquery</artifactId>
936+
<version>${jquery.version}</version>
937+
<type>jar</type>
938+
<overWrite>true</overWrite>
939+
<includes>**/jquery.min.js</includes>
940+
<fileMappers>
941+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
942+
</fileMappers>
943+
</artifactItem>
944+
<artifactItem>
945+
<groupId>org.webjars</groupId>
946+
<artifactId>tablesorter</artifactId>
947+
<version>${tablesorter.version}</version>
948+
<type>jar</type>
949+
<overWrite>true</overWrite>
950+
<includes>**/jquery.tablesorter.min.js,
951+
**/parsers/parser-date-iso8601.min.js</includes>
952+
<fileMappers>
953+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
954+
</fileMappers>
955+
</artifactItem>
956+
<artifactItem>
957+
<groupId>org.webjars</groupId>
958+
<artifactId>vega</artifactId>
959+
<version>${vega.version}</version>
960+
<type>jar</type>
961+
<overWrite>true</overWrite>
962+
<includes>**/vega.min.js</includes>
963+
<fileMappers>
964+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
965+
</fileMappers>
966+
</artifactItem>
967+
<artifactItem>
968+
<groupId>org.webjars</groupId>
969+
<artifactId>vega-embed</artifactId>
970+
<version>${vega-embed.version}</version>
971+
<type>jar</type>
972+
<overWrite>true</overWrite>
973+
<includes>**/vega-embed.min.js</includes>
974+
<fileMappers>
975+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
976+
</fileMappers>
977+
</artifactItem>
978+
<artifactItem>
979+
<groupId>org.webjars</groupId>
980+
<artifactId>vega-lite</artifactId>
981+
<version>${vega-lite.version}</version>
982+
<type>jar</type>
983+
<overWrite>true</overWrite>
984+
<includes>**/vega-lite.min.js</includes>
985+
<fileMappers>
986+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
987+
</fileMappers>
988+
</artifactItem>
989+
</artifactItems>
990+
<outputDirectory>${project.build.directory}/hbase-webapps/static/js</outputDirectory>
991+
</configuration>
992+
</execution>
993+
<execution>
994+
<id>unpack-ui-resources-css</id>
995+
<goals>
996+
<goal>unpack</goal>
997+
</goals>
998+
<phase>process-resources</phase>
999+
<configuration>
1000+
<artifactItems>
1001+
<artifactItem>
1002+
<groupId>org.webjars</groupId>
1003+
<artifactId>bootstrap</artifactId>
1004+
<version>${bootstrap.version}</version>
1005+
<type>jar</type>
1006+
<overWrite>true</overWrite>
1007+
<includes>**/css/bootstrap.min.css</includes>
1008+
<fileMappers>
1009+
<fileMapper implementation="org.codehaus.plexus.components.io.filemappers.FlattenFileMapper"/>
1010+
</fileMappers>
1011+
</artifactItem>
1012+
</artifactItems>
1013+
<outputDirectory>${project.build.directory}/hbase-webapps/static/css</outputDirectory>
1014+
</configuration>
1015+
</execution>
9121016
</executions>
9131017
</plugin>
9141018
</plugins>

‎hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
442442
<script src="/static/js/jquery.min.js" type="text/javascript"></script>
443443
<script src="/static/js/jquery.tablesorter.min.js" type="text/javascript"></script>
444444
<script src="/static/js/parser-date-iso8601.min.js" type="text/javascript"></script>
445-
<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
445+
<script src="/static/js/bootstrap.bundle.min.js" type="text/javascript"></script>
446446
<script src="/static/js/tab.js" type="text/javascript"></script>
447447
<script src="/static/js/jqSpager.js" type="text/javascript"></script>
448448
<script>

‎hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionVisualizerTmpl.jamon‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ See the License for the specific language governing permissions and
1717
limitations under the License.
1818
</%doc>
1919

20-
<script type="text/javascript" src="/static/js/vega@5.32.0.min.js"></script>
21-
<script type="text/javascript" src="/static/js/vega-lite@5.23.0.min.js"></script>
22-
<script type="text/javascript" src="/static/js/vega-embed@6.29.0.min.js"></script>
20+
<script type="text/javascript" src="/static/js/vega.min.js"></script>
21+
<script type="text/javascript" src="/static/js/vega-lite.min.js"></script>
22+
<script type="text/javascript" src="/static/js/vega-embed.min.js"></script>
2323

2424
<div id="vis" style="width:80%;"></div>
2525
<script type="text/javascript">

‎hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ org.apache.hadoop.hbase.zookeeper.MasterAddressTracker;
256256
</div>
257257
<script src="/static/js/jquery.min.js" type="text/javascript"></script>
258258
<script src="/static/js/jquery.tablesorter.min.js" type="text/javascript"></script>
259-
<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
259+
<script src="/static/js/bootstrap.bundle.min.js" type="text/javascript"></script>
260260
<script src="/static/js/tab.js" type="text/javascript"></script>
261261
<script>
262262
$(document).ready(function()

‎hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/tool/CanaryStatusTmpl.jamon‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ org.apache.hadoop.hbase.util.JvmVersion;
136136
</div> <!-- /container -->
137137

138138
<script src="/static/js/jquery.min.js" type="text/javascript"></script>
139-
<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
139+
<script src="/static/js/bootstrap.bundle.min.js" type="text/javascript"></script>
140140
<script src="/static/js/tab.js" type="text/javascript"></script>
141141
</body>
142142
</html>

‎hbase-server/src/main/resources/hbase-webapps/master/scripts.jsp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919
--%>
2020
<script src="/static/js/jquery.min.js" type="text/javascript"></script>
21-
<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
21+
<script src="/static/js/bootstrap.bundle.min.js" type="text/javascript"></script>
2222
<script src="/static/js/tab.js" type="text/javascript"></script>
2323
<script type="text/javascript">
2424
$(document).ready(function() {

‎hbase-server/src/main/resources/hbase-webapps/regionserver/footer.jsp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919
--%>
2020
<script src="/static/js/jquery.min.js" type="text/javascript"></script>
21-
<script src="/static/js/bootstrap.min.js" type="text/javascript"></script>
21+
<script src="/static/js/bootstrap.bundle.min.js" type="text/javascript"></script>
2222
<script src="/static/js/tab.js" type="text/javascript"></script>
2323
<script type="text/javascript">
2424
$(document).ready(function() {

‎hbase-server/src/main/resources/hbase-webapps/static/css/bootstrap.min.css‎

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)