HBASE-22729 Start RSGroupInfoManager as default #555

Apache9 · 2019-08-28T14:41:12Z

Amending-Author: Duo Zhang [email protected]

Apache-HBase · 2019-08-28T22:49:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
+1	mvninstall	324	HBASE-22514 passed
+1	compile	61	HBASE-22514 passed
+1	checkstyle	84	HBASE-22514 passed
+1	shadedjars	304	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	38	HBASE-22514 passed
0	spotbugs	261	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	259	HBASE-22514 passed
		_ Patch Compile Tests _
+1	mvninstall	323	the patch passed
+1	compile	61	the patch passed
+1	javac	61	the patch passed
+1	checkstyle	83	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	288	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	977	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	36	the patch passed
+1	findbugs	283	the patch passed
		_ Other Tests _
-1	unit	9915	hbase-server in the patch failed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		13510

Reason	Tests
Failed junit tests	hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/1/artifact/out/Dockerfile
GITHUB PR	#555
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e766f3832c53 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-555/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `548e8c4`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/1/testReport/
Max. process+thread count	4597 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack

Skimmed through. LGTM.

saintstack · 2019-09-02T06:10:52Z

hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java

 public class RSGroupInfo {
  public static final String DEFAULT_GROUP = "default";
  public static final String NAMESPACE_DESC_PROP_GROUP = "hbase.rsgroup.name";
+  public static final String TABLE_DESC_PROP_GROUP = "hbase.rsgroup.name";


Its intentional this and the define above have same value?

Yes, intentional. We can use the same name in namespace and table properties, the only problem is that the old name contains a 'NAMESPACE' and it is IA.Public, so we need to introduce a new 'TABLE' one.

Amending-Author: Duo Zhang <[email protected]>

Apache-HBase · 2019-09-03T01:19:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	77	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-22514 Compile Tests _
+1	mvninstall	372	HBASE-22514 passed
+1	compile	62	HBASE-22514 passed
+1	checkstyle	96	HBASE-22514 passed
+1	shadedjars	315	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	39	HBASE-22514 passed
0	spotbugs	298	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	296	HBASE-22514 passed
		_ Patch Compile Tests _
+1	mvninstall	442	the patch passed
+1	compile	82	the patch passed
+1	javac	82	the patch passed
+1	checkstyle	101	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	375	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1430	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	50	the patch passed
+1	findbugs	329	the patch passed
		_ Other Tests _
-1	unit	16858	hbase-server in the patch failed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		21503

Reason	Tests
Failed junit tests	hadoop.hbase.client.TestFromClientSide
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestFromClientSideWithCoprocessor
	hadoop.hbase.client.TestFromClientSide3

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/3/artifact/out/Dockerfile
GITHUB PR	#555
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 4e0b5d6c80bf 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-555/out/precommit/personality/provided.sh
git revision	HBASE-22514 / `78af5b7`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/3/testReport/
Max. process+thread count	4939 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-555/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

This reverts commit 58dee3e.

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit force-pushed the HBASE-22514 branch from 548e8c4 to ebd93b5 Compare September 1, 2019 14:14

saintstack approved these changes Sep 2, 2019

View reviewed changes

asfgit force-pushed the HBASE-22514 branch 2 times, most recently from e7e8029 to 78af5b7 Compare September 2, 2019 10:20

HBASE-22729 Start RSGroupInfoManager as default

25e7e45

Amending-Author: Duo Zhang <[email protected]>

Apache9 force-pushed the HBASE-22729 branch from c35b9da to 25e7e45 Compare September 2, 2019 10:45

Apache9 merged commit 4cd3611 into apache:HBASE-22514 Sep 3, 2019

asfgit pushed a commit that referenced this pull request Sep 4, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

855c092

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 7, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

f9e96bf

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 9, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

1686157

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 10, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

58dee3e

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 10, 2019

Revert "HBASE-22729 Start RSGroupInfoManager as default (#555)"

5a37c98

This reverts commit 58dee3e.

asfgit pushed a commit that referenced this pull request Sep 10, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

728d9fe

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 11, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

b44c6ad

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 11, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

7e77ad4

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 16, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

eaef4af

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 17, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

451c96f

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 18, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

f3198e5

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 20, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

d4672fc

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Sep 24, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

355e7b2

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Oct 5, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

11a200d

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Oct 28, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

6bb0e70

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Nov 5, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

39911b4

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Nov 10, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

90d4fb7

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Nov 13, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

09ea628

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Dec 24, 2019

HBASE-22729 Start RSGroupInfoManager as default (#555)

c30defe

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 2, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

be56e46

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 3, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

a05fcfd

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 4, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

86211cc

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 6, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

0d37785

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 7, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

21b35a1

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 8, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

9158346

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 9, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

fb0e524

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 12, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

294bf2a

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 20, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

0e76c4c

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 22, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

c8902c4

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 25, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

8304496

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 26, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

86a3e0d

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Feb 29, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

036cf27

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

Apache9 pushed a commit that referenced this pull request Mar 2, 2020

HBASE-22729 Start RSGroupInfoManager as default (#555)

2bf2781

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-22729 Start RSGroupInfoManager as default (apache#555)

ac913b2

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-22729 Start RSGroupInfoManager as default (apache#555)

6004d89

Amending-Author: Duo Zhang <[email protected]> Signed-off-by: stack <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-22729 Start RSGroupInfoManager as default #555

HBASE-22729 Start RSGroupInfoManager as default #555

Uh oh!

Apache9 commented Aug 28, 2019

Uh oh!

Apache-HBase commented Aug 28, 2019

Uh oh!

saintstack left a comment

Uh oh!

saintstack Sep 2, 2019

Uh oh!

Apache9 Sep 2, 2019

Uh oh!

Apache-HBase commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-22729 Start RSGroupInfoManager as default #555

HBASE-22729 Start RSGroupInfoManager as default #555

Uh oh!

Conversation

Apache9 commented Aug 28, 2019

Uh oh!

Apache-HBase commented Aug 28, 2019

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

saintstack Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

Apache9 Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants