Skip to content

Commit 5a37c98

Browse files
committed
Revert "HBASE-22729 Start RSGroupInfoManager as default (#555)"
This reverts commit 58dee3e.
1 parent 58dee3e commit 5a37c98

5 files changed

Lines changed: 3 additions & 27 deletions

File tree

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@
186186
import org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner;
187187
import org.apache.hadoop.hbase.replication.master.ReplicationPeerConfigUpgrader;
188188
import org.apache.hadoop.hbase.replication.regionserver.ReplicationStatus;
189-
import org.apache.hadoop.hbase.rsgroup.RSGroupInfoManager;
190189
import org.apache.hadoop.hbase.security.AccessDeniedException;
191190
import org.apache.hadoop.hbase.security.SecurityConstants;
192191
import org.apache.hadoop.hbase.security.UserProvider;
@@ -351,8 +350,6 @@ public void run() {
351350
// manager of assignment nodes in zookeeper
352351
private AssignmentManager assignmentManager;
353352

354-
private RSGroupInfoManager rsGroupInfoManager;
355-
356353
// manager of replication
357354
private ReplicationPeerManager replicationPeerManager;
358355

@@ -775,8 +772,6 @@ protected void initializeZKBasedSystemTrackers()
775772
this.splitOrMergeTracker = new SplitOrMergeTracker(zooKeeper, conf, this);
776773
this.splitOrMergeTracker.start();
777774

778-
this.rsGroupInfoManager = RSGroupInfoManager.create(this);
779-
780775
this.replicationPeerManager = ReplicationPeerManager.create(zooKeeper, conf);
781776

782777
this.drainingServerTracker = new DrainingServerTracker(zooKeeper, this, this.serverManager);
@@ -3756,9 +3751,4 @@ public Map<String, ReplicationStatus> getWalGroupsReplicationStatus() {
37563751
public HbckChore getHbckChore() {
37573752
return this.hbckChore;
37583753
}
3759-
3760-
@Override
3761-
public RSGroupInfoManager getRSRSGroupInfoManager() {
3762-
return rsGroupInfoManager;
3763-
}
37643754
}

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@
1818
package org.apache.hadoop.hbase.master;
1919

2020
import com.google.protobuf.Service;
21+
2122
import java.io.IOException;
2223
import java.util.List;
24+
2325
import org.apache.hadoop.hbase.Server;
2426
import org.apache.hadoop.hbase.ServerName;
2527
import org.apache.hadoop.hbase.TableDescriptors;
@@ -49,7 +51,6 @@
4951
import org.apache.hadoop.hbase.replication.ReplicationPeerConfig;
5052
import org.apache.hadoop.hbase.replication.ReplicationPeerDescription;
5153
import org.apache.hadoop.hbase.replication.SyncReplicationState;
52-
import org.apache.hadoop.hbase.rsgroup.RSGroupInfoManager;
5354
import org.apache.hadoop.hbase.security.access.AccessChecker;
5455
import org.apache.hadoop.hbase.security.access.ZKPermissionWatcher;
5556
import org.apache.yetus.audience.InterfaceAudience;
@@ -536,8 +537,4 @@ default SplitWALManager getSplitWALManager(){
536537
*/
537538
List<RegionPlan> executeRegionPlansWithThrottling(List<RegionPlan> plans);
538539

539-
/**
540-
* @return the {@link RSGroupInfoManager}
541-
*/
542-
RSGroupInfoManager getRSRSGroupInfoManager();
543540
}

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void start(CoprocessorEnvironment env) throws IOException {
6666
}
6767

6868
master = ((HasMasterServices) env).getMasterServices();
69-
groupInfoManager = master.getRSRSGroupInfoManager();
69+
groupInfoManager = RSGroupInfoManagerImpl.getInstance(master);
7070
groupAdminServer = new RSGroupAdminServer(master, groupInfoManager);
7171
Class<?> clazz =
7272
master.getConfiguration().getClass(HConstants.HBASE_MASTER_LOADBALANCER_CLASS, null);

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.util.List;
2222
import java.util.Set;
2323
import org.apache.hadoop.hbase.TableName;
24-
import org.apache.hadoop.hbase.master.MasterServices;
2524
import org.apache.hadoop.hbase.net.Address;
2625
import org.apache.yetus.audience.InterfaceAudience;
2726

@@ -88,8 +87,4 @@ Set<Address> moveServers(Set<Address> servers, String srcGroup, String dstGroup)
8887
*/
8988
@Deprecated
9089
RSGroupInfo getRSGroupForTable(TableName tableName) throws IOException;
91-
92-
static RSGroupInfoManager create(MasterServices master) throws IOException {
93-
return RSGroupInfoManagerImpl.getInstance(master);
94-
}
9590
}

hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockNoopMasterServices.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
import org.apache.hadoop.hbase.replication.ReplicationPeerConfig;
5555
import org.apache.hadoop.hbase.replication.ReplicationPeerDescription;
5656
import org.apache.hadoop.hbase.replication.SyncReplicationState;
57-
import org.apache.hadoop.hbase.rsgroup.RSGroupInfoManager;
5857
import org.apache.hadoop.hbase.security.access.AccessChecker;
5958
import org.apache.hadoop.hbase.security.access.ZKPermissionWatcher;
6059
import org.apache.hadoop.hbase.zookeeper.ZKWatcher;
@@ -491,9 +490,4 @@ public List<RegionPlan> executeRegionPlansWithThrottling(List<RegionPlan> plans)
491490
public AsyncClusterConnection getAsyncClusterConnection() {
492491
return null;
493492
}
494-
495-
@Override
496-
public RSGroupInfoManager getRSRSGroupInfoManager() {
497-
return null;
498-
}
499493
}

0 commit comments

Comments
 (0)