HBASE-22508 Address findbugs/spotbugs complaints (branch-1.3)

hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MetricsExecutorImpl.java

@@ -48,7 +48,7 @@ public void stop() {
 
   private enum ExecutorSingleton {
     INSTANCE;
-    private final ScheduledExecutorService scheduler = new ScheduledThreadPoolExecutor(1,
+    private transient final ScheduledExecutorService scheduler = new ScheduledThreadPoolExecutor(1,
         new ThreadPoolExecutorThreadFactory("HBase-Metrics2-"));
   }
 

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

@@ -7812,11 +7812,15 @@ public Result append(Append mutate, long nonceGroup, long nonce) throws IOExcept
         for (Map.Entry<Store, List<Cell>> entry : removedCellsForMemStore.entrySet()) {
           Store currStore = entry.getKey();
           for (Cell cell: entry.getValue()) {
-            CellUtil.setSequenceId(cell, walKey.getWriteEntry().getWriteNumber());
+            if (we != null) {
+              CellUtil.setSequenceId(cell, we.getWriteNumber());
+            }
             currStore.add(cell);
           }
         }
-        if (we != null) mvcc.complete(we);
+        if (we != null) {
+          mvcc.complete(we);
+        }
       } else if (we != null) {
         mvcc.completeAndWait(we);
       }
@@ -8042,20 +8046,27 @@ private Result doIncrement(Increment increment, long nonceGroup, long nonce) thr
         rowLock.release();
       }
       // if the wal sync was unsuccessful, remove keys from memstore
+      WriteEntry we = walKey != null ? walKey.getWriteEntry() : null;
       if (doRollBackMemstore) {
         for (Map.Entry<Store, List<Cell>> entry : forMemStore.entrySet()) {
           rollbackMemstore(entry.getKey(), entry.getValue());
         }
         for (Map.Entry<Store, List<Cell>> entry : removedCellsForMemStore.entrySet()) {
           Store currStore = entry.getKey();
           for (Cell cell : entry.getValue()) {
-            CellUtil.setSequenceId(cell, walKey.getWriteEntry().getWriteNumber());
+            if (we != null) {
+              CellUtil.setSequenceId(cell, we.getWriteNumber());
+            }
             currStore.add(cell);
           }
         }
-        if (walKey != null) mvcc.complete(walKey.getWriteEntry());
+        if (we != null) {
+          mvcc.complete(we);
+        }
       } else {
-        if (walKey != null) mvcc.completeAndWait(walKey.getWriteEntry());
+        if (we != null) {
+          mvcc.completeAndWait(we);
+        }
       }
     }
 

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

@@ -2806,10 +2806,14 @@ private void removeCompactedfiles(Collection<StoreFile> compactedfiles)
             // Just close and return
             filesToRemove.add(file);
           } else {
-            LOG.info("Can't archive compacted file " + file.getPath()
+            if (r != null) {
+              LOG.info("Can't archive compacted file " + file.getPath()
                 + " because of either isCompactedAway=" + r.isCompactedAway()
                 + " or file has reference, isReferencedInReads=" + r.isReferencedInReads()
                 + ", refCount=" + r.getRefCount() + ", skipping for now.");
+            } else {
+              LOG.info("Can't archive compacted file " + file.getPath() + ", skipping for now.");
+            }
           }
         } catch (Exception e) {
           LOG.error(

hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java

@@ -35,6 +35,7 @@
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Random;
 import java.util.Set;
 import java.util.TreeSet;
@@ -1089,7 +1090,8 @@ public void run() {
             }
           }
           Map<String, AtomicLong> actualReadTableLatency = regionSink.getReadLatencyMap();
-          for (String tableName : this.configuredReadTableTimeouts.keySet()) {
+          for (Entry<String, Long> entry : this.configuredReadTableTimeouts.entrySet()) {
+            String tableName = entry.getKey();
             if (actualReadTableLatency.containsKey(tableName)) {
               Long actual = actualReadTableLatency.get(tableName).longValue();
               Long configured = this.configuredReadTableTimeouts.get(tableName);