Skip to content

Conversation

@apurtell
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 1094 Docker mode activated.
_ Prechecks _
0 findbugs 1 Findbugs executables are not available.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
0 mvndep 49 Maven dependency ordering for branch
+1 mvninstall 104 branch-1.3 passed
+1 compile 48 branch-1.3 passed with JDK v1.8.0_212
+1 compile 54 branch-1.3 passed with JDK v1.7.0_222
+1 checkstyle 93 branch-1.3 passed
+1 shadedjars 141 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 37 branch-1.3 passed with JDK v1.8.0_212
+1 javadoc 55 branch-1.3 passed with JDK v1.7.0_222
_ Patch Compile Tests _
0 mvndep 12 Maven dependency ordering for patch
+1 mvninstall 100 the patch passed
+1 compile 48 the patch passed with JDK v1.8.0_212
+1 javac 48 the patch passed
+1 compile 55 the patch passed with JDK v1.7.0_222
+1 javac 55 the patch passed
+1 checkstyle 12 The patch passed checkstyle in hbase-hadoop2-compat
+1 checkstyle 78 hbase-server: The patch generated 0 new + 420 unchanged - 3 fixed = 420 total (was 423)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 139 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 416 Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
+1 javadoc 38 the patch passed with JDK v1.8.0_212
+1 javadoc 52 the patch passed with JDK v1.7.0_222
_ Other Tests _
+1 unit 29 hbase-hadoop2-compat in the patch passed.
+1 unit 7711 hbase-server in the patch passed.
+1 asflicense 42 The patch does not generate ASF License warnings.
10491
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-275/1/artifact/out/Dockerfile
GITHUB PR #275
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux cafc39d84bff 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-1.3 / 911f98c
maven version: Apache Maven 3.0.5
Default Java 1.7.0_222
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-275/1/testReport/
Max. process+thread count 3838 (vs. ulimit of 10000)
modules C: hbase-hadoop2-compat hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-275/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@apurtell
Copy link
Contributor Author

Precommit looks good. I'm going to merge this so I can get out the RC. Will wait a few hours if @busbey has any comments

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me. I've just been waiting for a chance to run findbugs locally since the QA Bot for PRs doesn't have the stuff it needs for findbugs.

presuming you've already done that I'm good.

@apurtell
Copy link
Contributor Author

apurtell commented Jun 1, 2019

Yes, I used eclipse to run findbugs on the modified compilation units.

asfgit pushed a commit that referenced this pull request Jun 1, 2019
@apurtell apurtell closed this Jun 1, 2019
@apurtell apurtell deleted the HBASE-22508-branch-1.3 branch June 1, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants