Skip to content

Conversation

@gkanade
Copy link
Contributor

@gkanade gkanade commented Apr 17, 2020

Corrected this

Copy link
Contributor

@binlijin binlijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ramkrish86 ramkrish86 merged commit 12aad76 into apache:master Apr 17, 2020
@ramkrish86
Copy link
Contributor

Thanks for the patch @gkanade and thanks for the review @binlijin .

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 12s master passed
+1 💚 checkstyle 1m 16s master passed
+1 💚 spotbugs 2m 20s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 46s the patch passed
+1 💚 checkstyle 1m 14s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 6m 4s Patch does not cause any errors with Hadoop 3.1.2.
+1 💚 spotbugs 2m 53s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
31m 14s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1539
JIRA Issue HBASE-24177
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux b4f383cefafe 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7a6d36
Max. process+thread count 84 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 34s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 17s master passed
+1 💚 compile 1m 3s master passed
+1 💚 shadedjars 5m 35s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 49s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 shadedjars 5m 21s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s the patch passed
_ Other Tests _
-1 ❌ unit 8m 25s hbase-server in the patch failed.
33m 16s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #1539
JIRA Issue HBASE-24177
Optional Tests javac javadoc unit shadedjars compile
uname Linux c89e511dc777 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7a6d36
Default Java 1.8.0_232
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/testReport/
Max. process+thread count 753 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ramkrish86
Copy link
Contributor

Seems like some QA bot issue.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 22s master passed
+1 💚 compile 1m 3s master passed
+1 💚 shadedjars 5m 6s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 42s hbase-server in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 53s the patch passed
+1 💚 compile 1m 4s the patch passed
+1 💚 javac 1m 4s the patch passed
+1 💚 shadedjars 5m 5s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 39s hbase-server in the patch failed.
_ Other Tests _
+1 💚 unit 119m 21s hbase-server in the patch passed.
143m 41s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1539
JIRA Issue HBASE-24177
Optional Tests javac javadoc unit shadedjars compile
uname Linux d19b25919893 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b7a6d36
Default Java 2020-01-14
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/testReport/
Max. process+thread count 4580 (vs. ulimit of 12500)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1539/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@ramkrish86
Copy link
Contributor

Javadoc failure is not related to this patch.

ramkrish86 pushed a commit that referenced this pull request Apr 17, 2020
Authored-by: Gaurav Kanade <[email protected]>
Signed-off-by: Ramkrishna <[email protected]>
ramkrish86 pushed a commit that referenced this pull request Apr 17, 2020
Authored-by: Gaurav Kanade <[email protected]>
Signed-off-by: Ramkrishna <[email protected]>
ramkrish86 pushed a commit that referenced this pull request Apr 17, 2020
Authored-by: Gaurav Kanade <[email protected]>
Signed-off-by: Ramkrishna <[email protected]>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Apr 20, 2020
Authored-by: Gaurav Kanade <[email protected]>
Signed-off-by: Ramkrishna <[email protected]>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
Authored-by: Gaurav Kanade <[email protected]>
Signed-off-by: Ramkrishna <[email protected]>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
Authored-by: Gaurav Kanade <[email protected]>
Signed-off-by: Ramkrishna <[email protected]>
(cherry picked from commit e67d751)

Change-Id: Ia7c08610442e98d6efb6c7aefcfbf1eaf4691f4f
Apache9 added a commit that referenced this pull request Sep 30, 2024
Apache9 pushed a commit that referenced this pull request Sep 30, 2024
Apache9 added a commit that referenced this pull request Sep 30, 2024
Apache9 pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants