MetricsTable#updateFlushTime is wrong (#1539)

gkanade · Ramkrishna Vasudevan · commit e67d7516ec4b · 2020-04-17T17:43:35.000+05:30
Authored-by: Gaurav Kanade &lt;gkanade@microsoft.com&gt;
Signed-off-by: Ramkrishna &lt;ramkrishna@apache.org&gt;
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
@@ -212,7 +212,7 @@ public void updateFlush(String table, long t, long memstoreSize, long fileSize)
     serverSource.updateFlushOutputSize(fileSize);
 
     if (table != null) {
-      metricsTable.updateFlushTime(table, memstoreSize);
+      metricsTable.updateFlushTime(table, t);
       metricsTable.updateFlushMemstoreSize(table, memstoreSize);
       metricsTable.updateFlushOutputSize(table, fileSize);
     }

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ public void updateFlush(String table, long t, long memstoreSize, long fileSize)`
`212`	`212`	`serverSource.updateFlushOutputSize(fileSize);`
`213`	`213`
`214`	`214`	`if (table != null) {`
`215`		`- metricsTable.updateFlushTime(table, memstoreSize);`
	`215`	`+ metricsTable.updateFlushTime(table, t);`
`216`	`216`	`metricsTable.updateFlushMemstoreSize(table, memstoreSize);`
`217`	`217`	`metricsTable.updateFlushOutputSize(table, fileSize);`
`218`	`218`	`}`