-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…emoved reflections in CommonFSUtils
| "local filesystem implementation doesn't support storage policies.", exception); | ||
| } | ||
| // check for lack of HDFS-7228 | ||
| if (e instanceof InvocationTargetException) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be two direct checks for RemoteException and UnsupportedOperationException respectively. Now that we're not using reflection it won't be wrapped in InvocationTargetException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the outer check for the InvocationTargetException.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
Based on the feedback from Sean on #1034.