Skip to content

Conversation

@HorizonNet
Copy link
Contributor

Based on the feedback from Sean on #1034.

@HorizonNet HorizonNet requested a review from busbey January 14, 2020 16:55
"local filesystem implementation doesn't support storage policies.", exception);
}
// check for lack of HDFS-7228
if (e instanceof InvocationTargetException) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be two direct checks for RemoteException and UnsupportedOperationException respectively. Now that we're not using reflection it won't be wrapped in InvocationTargetException

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the outer check for the InvocationTargetException.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for branch
+1 💚 mvninstall 6m 27s master passed
+1 💚 compile 0m 38s master passed
+1 💚 checkstyle 2m 38s master passed
+1 💚 shadedjars 4m 41s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s master passed
+0 🆗 spotbugs 0m 48s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 🆗 findbugs 0m 16s branch/hbase-checkstyle no findbugs output file (findbugsXml.xml)
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 58s the patch passed
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 38s the patch passed
+1 💚 checkstyle 2m 34s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 shadedjars 4m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 15m 36s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 35s the patch passed
+0 🆗 findbugs 0m 14s hbase-checkstyle has no data from findbugs
_ Other Tests _
+1 💚 unit 0m 14s hbase-checkstyle in the patch passed.
+1 💚 unit 3m 19s hbase-common in the patch passed.
+1 💚 unit 153m 29s hbase-server in the patch passed.
+1 💚 asflicense 1m 0s The patch does not generate ASF License warnings.
211m 59s
Subsystem Report/Notes
Docker Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1036/2/artifact/out/Dockerfile
GITHUB PR #1036
Optional Tests dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile
uname Linux bbfc7495a56d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1036/out/precommit/personality/provided.sh
git revision master / 499ff32
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1036/2/testReport/
Max. process+thread count 5535 (vs. ulimit of 10000)
modules C: hbase-checkstyle hbase-common U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1036/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants