HBASE-23622 Reduced the number of Checkstyle violations in hbase-common #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
busbey
requested changes
Jan 14, 2020
Contributor
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
If we want to do the binary incompatible changes we need a draft release note for how we'll call them out. otherwise please update to remove binary incompatible changes.
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteRangeUtils.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
Outdated
Show resolved
Hide resolved
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
Outdated
Show resolved
Hide resolved
| try { | ||
| m = fs.getClass().getDeclaredMethod("setStoragePolicy", | ||
| new Class<?>[] { Path.class, String.class }); | ||
| m = fs.getClass().getDeclaredMethod("setStoragePolicy", Path.class, String.class); |
Contributor
There was a problem hiding this comment.
branch-1's minimum hadoop version is 2.8.5, so for that branch we can remove this reflection as well. Note to potential further backporters: the method is not in Hadoop 2.7, we'll need this reflection in branch-1.4 and branch-1.3.
Contributor
Author
There was a problem hiding this comment.
Removed the reflection part. Will create additional backports for branch-1.4 and branch-1.3.
busbey
requested changes
Jan 14, 2020
| "more information see the 'ArchivalStorage' docs for your Hadoop release."); | ||
| } | ||
| // check for lack of HDFS-7228 | ||
| if (e instanceof InvocationTargetException) { |
Contributor
There was a problem hiding this comment.
Now that we're not using reflection, this should be a direct check for RemoteException because it won't be wrapped in the reflection invocation exception.
Contributor
Author
There was a problem hiding this comment.
Updated the changes to unwrap the InvocationTargetException check.
This comment has been minimized.
This comment has been minimized.
|
💔 -1 overall
This message was automatically generated. |
busbey
requested changes
Jan 14, 2020
| m.invoke(fs, path, storagePolicy); | ||
|
|
||
| // check for lack of HDFS-7228 | ||
| final Throwable exception = e.getCause(); |
Contributor
There was a problem hiding this comment.
I don't think this is correct. wouldn't e be the RemoteException?
Contributor
Author
There was a problem hiding this comment.
Yes, you're right. I removed the part of getting the cause.
|
💔 -1 overall
This message was automatically generated. |
busbey
approved these changes
Jan 15, 2020
Contributor
Author
|
Problem in the build seems to be related to HBASE-22732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #968 to branch-1.