Skip to content

YARN-11899. TestRouterMetrics is order dependent #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
18chanp1 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+16 −1
Open

YARN-11899. TestRouterMetrics is order dependent #8133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ...n-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@

import static org.junit.jupiter.api.Assertions.assertEquals;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -62,6 +64,19 @@ public static void init() {
LOG.info("Test: aggregate metrics are updated correctly");
}

@BeforeEach
public void setup() {
//reset metrics before each test
RouterMetrics.destroy();
metrics = RouterMetrics.getMetrics();
}

@AfterEach
public void tearDown() {
RouterMetrics.destroy();
metrics = RouterMetrics.getMetrics();
}

/**
Comment on lines +67 to 80
Copy link
Member

@ayushtkn ayushtkn Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't just doing in BeforeEach enough?

* This test validates the correctness of the metric: Created Apps
* successfully.
Expand Down Expand Up @@ -2379,4 +2394,4 @@ public void testDeleteFederationPoliciesByQueuesRetrieved() {
metrics.getLatencySucceededDeleteFederationPoliciesByQueuesRetrieved(),
ASSERT_DOUBLE_DELTA);
}
}
}