-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11899. TestRouterMetrics is order dependent #8133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
18chanp1
wants to merge
1
commit into
apache:trunk
Choose a base branch
from
18chanp1:l2100
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally invoking reset
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Dec 22, 2025
Comment on lines
+67
to
80
| @BeforeEach | ||
| public void setup() { | ||
| //reset metrics before each test | ||
| RouterMetrics.destroy(); | ||
| metrics = RouterMetrics.getMetrics(); | ||
| } | ||
|
|
||
| @AfterEach | ||
| public void tearDown() { | ||
| RouterMetrics.destroy(); | ||
| metrics = RouterMetrics.getMetrics(); | ||
| } | ||
|
|
||
| /** |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't just doing in BeforeEach enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The following tests are order dependent if they are interleaved with some other tests.
I believe this is because the Router is being used by some other module, causing the statistics to be inaccurate. To address this problem,
RouterMetricsshould be reset before and after every test. This PR creates a setup and teardown to perform this actionHow was this patch tested?
Existing tests in TestRouterMetrics that pass continue to pass, and tests that fail in TestRouterMetrics continue to fail.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?