YARN-11554. Fix TestRMFailover#testWebAppProxyInStandAloneMode Failed. by slfan1989 · Pull Request #5971 · apache/hadoop

slfan1989 · 2023-08-21T13:29:51Z

Description of PR

JIRA: YARN-11554. Fix TestRMFailover#testWebAppProxyInStandAloneMode Failed.

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2023-08-21T16:17:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	48m 25s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 28s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 26s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	0m 57s		trunk passed
+1 💚	shadedclient	38m 22s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	0m 53s		the patch passed
+1 💚	shadedclient	38m 11s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	27m 59s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 37s		The patch does not generate ASF License warnings.
		165m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/1/artifact/out/Dockerfile
GITHUB PR	#5971
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b7b39d1d4aee 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `af77305`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/1/testReport/
Max. process+thread count	603 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

simbadzina · 2023-08-22T00:17:39Z

  public void testWebAppProxyInStandAloneMode() throws YarnException,
      InterruptedException, IOException {
    conf.setBoolean(YarnConfiguration.AUTO_FAILOVER_ENABLED, false);
+    if (HAUtil.isHAEnabled(conf)) {


HAUtil.isHAEnabled() is always true, since it is set in the setup of this test here: https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestRMFailover.java#L88

Can you remove the check.

Thanks for your suggestion! I will remove if (HAUtil.isHAEnabled(conf)).

hadoop-yetus · 2023-08-22T15:36:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 2s		codespell was not available.
+0 🆗	detsecrets	0m 2s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	50m 47s		trunk passed
+1 💚	compile	0m 38s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 32s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 36s		trunk passed
+1 💚	javadoc	0m 36s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 1s		trunk passed
+1 💚	shadedclient	39m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 17s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)
+1 💚	mvnsite	0m 28s		the patch passed
+1 💚	javadoc	0m 25s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 21s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	1m 6s		the patch passed
+1 💚	shadedclient	41m 53s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	29m 12s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 41s		The patch does not generate ASF License warnings.
		175m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/2/artifact/out/Dockerfile
GITHUB PR	#5971
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 2b9726aecadd 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `39f505f`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/2/testReport/
Max. process+thread count	599 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

simbadzina

LGTM. Just one unused import to fix.

simbadzina · 2023-08-22T16:31:04Z

 import org.apache.hadoop.util.ExitUtil;
 import org.apache.hadoop.yarn.api.records.ApplicationId;
 import org.apache.hadoop.yarn.client.api.YarnClient;
+import org.apache.hadoop.yarn.conf.HAUtil;


Unused import

Thank you for helping the review code! I will improve the code.

hadoop-yetus · 2023-08-28T04:25:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	49m 11s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	0m 29s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 31s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	0m 58s		trunk passed
+1 💚	shadedclient	38m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s		the patch passed
+1 💚	compile	0m 27s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 27s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	0m 54s		the patch passed
+1 💚	shadedclient	38m 16s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	28m 4s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		167m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/3/artifact/out/Dockerfile
GITHUB PR	#5971
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 8ed52190648e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d9058a9`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/3/testReport/
Max. process+thread count	554 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5971/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2023-08-30T15:57:43Z

@goiri Can you help review this pr? Thank you very much! I found this unit test error while completing #5967 , #5957 .

#5967 YARN-11435. [Router] FederationStateStoreFacade is not reinitialized with Router conf.
#5957 YARN-6537. Consider running RM tests against the Router.

slfan1989 · 2023-08-31T22:53:44Z

@goiri Thank you very much for your help in reviewing the code!

apache#5971)

YARN-11554. Fix TestRMFailover#testWebAppProxyInStandAloneMode Failed.

af77305

github-actions Bot added YARN trunk labels Aug 21, 2023

simbadzina reviewed Aug 22, 2023

View reviewed changes

YARN-11554. Fix CheckStyle.

39f505f

simbadzina reviewed Aug 22, 2023

View reviewed changes

YARN-11554. Fix CheckStyle.

d9058a9

simbadzina approved these changes Aug 28, 2023

View reviewed changes

goiri approved these changes Aug 31, 2023

View reviewed changes

goiri merged commit b6d06c8 into apache:trunk Aug 31, 2023

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

YARN-11554. Fix TestRMFailover#testWebAppProxyInStandAloneMode Failed. (

430542d

apache#5971)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11554. Fix TestRMFailover#testWebAppProxyInStandAloneMode Failed.#5971

YARN-11554. Fix TestRMFailover#testWebAppProxyInStandAloneMode Failed.#5971
goiri merged 3 commits intoapache:trunkfrom
slfan1989:YARN-11554

slfan1989 commented Aug 21, 2023

Uh oh!

hadoop-yetus commented Aug 21, 2023

Uh oh!

simbadzina Aug 22, 2023 •

edited

Loading

Uh oh!

slfan1989 Aug 22, 2023

Uh oh!

hadoop-yetus commented Aug 22, 2023

Uh oh!

simbadzina left a comment

Uh oh!

simbadzina Aug 22, 2023

Uh oh!

slfan1989 Aug 28, 2023

Uh oh!

hadoop-yetus commented Aug 28, 2023

Uh oh!

slfan1989 commented Aug 30, 2023

Uh oh!

slfan1989 commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

slfan1989 commented Aug 21, 2023

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Aug 21, 2023

Uh oh!

simbadzina Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slfan1989 Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 22, 2023

Uh oh!

simbadzina left a comment

Choose a reason for hiding this comment

Uh oh!

simbadzina Aug 22, 2023

Choose a reason for hiding this comment

Uh oh!

slfan1989 Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 28, 2023

Uh oh!

slfan1989 commented Aug 30, 2023

Uh oh!

slfan1989 commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

simbadzina Aug 22, 2023 •

edited

Loading