YARN-11435. [Router] FederationStateStoreFacade is not reinitialized with Router conf.#5967
Merged
slfan1989 merged 3 commits intoapache:trunkfrom Sep 3, 2023
Merged
YARN-11435. [Router] FederationStateStoreFacade is not reinitialized with Router conf.#5967slfan1989 merged 3 commits intoapache:trunkfrom
slfan1989 merged 3 commits intoapache:trunkfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Can you help review this pr? Thank you very much! |
goiri
reviewed
Aug 26, 2023
| public static FederationStateStoreFacade getInstance() { | ||
| return FACADE; | ||
| public static FederationStateStoreFacade getInstance(Configuration conf) { | ||
| if(facade == null) { |
Member
There was a problem hiding this comment.
Can we exit early?
if (facade != null) {
return facade;
}
Contributor
Author
There was a problem hiding this comment.
Thank you very much for your help in reviewing the code! I will improve this part of the code.
| policyConfiguration) throws YarnException { | ||
| FederationStateStoreFacade goodFacade = FederationStateStoreFacade | ||
| .getInstance(); | ||
| .getInstance(new Configuration()); |
Member
There was a problem hiding this comment.
Can we have an empty getInstance() that does the new Configuration?
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion! I will provide an empty getInstance.
|
💔 -1 overall
This message was automatically generated. |
4 tasks
goiri
approved these changes
Aug 31, 2023
|
🎊 +1 overall
This message was automatically generated. |
…with Router conf.
slfan1989
force-pushed
the
YARN-11435
branch
from
3c28d30 to
ef83c6d
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
@goiri Thank you very much for your help in reviewing the code! I will continue to follow up YARN-11433 And YARN-11434. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…with Router conf. (apache#5967) Contributed by Shilun Fan. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11435. [Router] FederationStateStoreFacade is not reinitialized with Router conf.
When implementing the FederationStateStoreFacade, we opted for the singleton pattern. However, our FederationStateStoreFacade singleton implementation used a newly created Configuration when creating the singleton, without considering the configuration differences of the calling class. In this PR, we have refactored this portion of the code using the Double Checked Locking method of the singleton pattern, allowing the FederationStateStoreFacade to be aware of the configuration differences of the calling class.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?