Skip to content

HDFS-16947. RBF NamenodeHeartbeatService to report error for not being able to register namenode in state store #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jojochuang merged 2 commits into from
Mar 15, 2023
Merged

HDFS-16947. RBF NamenodeHeartbeatService to report error for not being able to register namenode in state store #5470

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67c4a12
HDFS-16947. RBF NamenodeHeartbeatService to report error for not bein…
virajjasani Mar 9, 2023
e08544b
addendum
virajjasani Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ private void updateState() {
LOG.warn("Cannot register namenode {}", report);
}
} catch (IOException e) {
LOG.info("Cannot register namenode in the State Store");
LOG.error("Cannot register namenode in the State Store", e);
} catch (Exception ex) {
LOG.error("Unhandled exception updating NN registration for {}",
getNamenodeDesc(), ex);
Copy link
Member

@ayushtkn ayushtkn Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge the both blocks, now both are logging error, with the later just having additional getNamenodeDesc

Copy link
Contributor Author

@virajjasani virajjasani Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, so you mean having getNamenodeDesc in general for both is fine right? I think that's good idea

Copy link
Member

@ayushtkn ayushtkn Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Expand Down