HDFS-16947. RBF NamenodeHeartbeatService to report error for not being able to register namenode in state store #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g able to register namenode in state store
Contributor
Author
|
@goiri @slfan1989 could you please review this PR? |
|
💔 -1 overall
This message was automatically generated. |
jojochuang
approved these changes
Mar 9, 2023
ayushtkn
reviewed
Mar 10, 2023
Comment on lines
320
to
324
| } catch (IOException e) { | ||
| LOG.info("Cannot register namenode in the State Store"); | ||
| LOG.error("Cannot register namenode in the State Store", e); | ||
| } catch (Exception ex) { | ||
| LOG.error("Unhandled exception updating NN registration for {}", | ||
| getNamenodeDesc(), ex); |
Member
There was a problem hiding this comment.
can we merge the both blocks, now both are logging error, with the later just having additional getNamenodeDesc
Contributor
Author
There was a problem hiding this comment.
Sounds good, so you mean having getNamenodeDesc in general for both is fine right? I think that's good idea
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Mar 14, 2023
ferdelyi
pushed a commit
to ferdelyi/hadoop
that referenced
this pull request
May 26, 2023
…g able to register namenode in state store (apache#5470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namenode heartbeat service should provide error with full stacktrace if it cannot register namenode in the state store. As of today, we only log info msg.
For zookeeper based impl, this might mean either a) curator manager is not initialized or b) if it fails to write to znode after exhausting retries. For either of these cases, reporting only INFO log might not be good enough and we might have to look for errors elsewhere.
Sample example:
If we could log full stacktrace: