Skip to content

YARN-11078. Set env vars in a cross platform compatible way #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GauthamBanasandra merged 3 commits into from
Jun 15, 2022
Merged

YARN-11078. Set env vars in a cross platform compatible way #4432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9feba53
YARN-11078. Set env vars in a cross platform compatible way
GauthamBanasandra Jun 12, 2022
ebd0413
Run CI
GauthamBanasandra Jun 12, 2022
c5e018e
Revert "Run CI"
GauthamBanasandra Jun 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,34 @@

<build>
<plugins>
<!-- Pkck the appropriate ember build script to use in src/package.json based on the OS -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<version>1.8</version>
<executions>
<execution>
<phase>validate</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<exportAntProperties>true</exportAntProperties>
<target>
<!-- Set the Maven property emberBuildScript to build:mvn:windows if this is
running on Windows. Set it to build:mvn otherwise. -->
<condition property="emberBuildScript" value="build:mvn:windows" else="build:mvn">
<and>
<os family="windows"/>
</and>
</condition>
<echo>Ember build script to use = ${emberBuildScript}</echo>
</target>
</configuration>
</execution>
</executions>
</plugin>

<!-- Apache RAT -->
<plugin>
<groupId>org.apache.rat</groupId>
Expand Down Expand Up @@ -229,7 +257,7 @@
<arguments>
<argument>${packageManagerScript}</argument>
<argument>run</argument>
<argument>build:mvn</argument>
<argument>${emberBuildScript}</argument>
</arguments>
</configuration>
</execution>
Expand Down
3 changes: 2 additions & 1 deletion hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"scripts": {
"build": "TMPDIR=tmp node ./node_modules/ember-cli/bin/ember build",
"start": "TMPDIR=tmp node ./node_modules/ember-cli/bin/ember server",
"build:mvn": "TMPDIR=tmp node/node ./node_modules/ember-cli/bin/ember build -prod"
"build:mvn": "TMPDIR=tmp node/node ./node_modules/ember-cli/bin/ember build -prod",
"build:mvn:windows": "set TMPDIR=tmp; node/node ./node_modules/ember-cli/bin/ember build -prod"
},
"repository": "",
"engines": {
Expand Down