Skip to content

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Feb 13, 2025

What is the purpose of the change?

try to solve dubbo-samples-configcenter-apollo sample test failure issue

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.84%. Comparing base (bc729af) to head (97317ce).
⚠️ Report is 244 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15130      +/-   ##
============================================
+ Coverage     58.83%   58.84%   +0.01%     
  Complexity       12       12              
============================================
  Files          1883     1884       +1     
  Lines         86013    86050      +37     
  Branches      12886    12893       +7     
============================================
+ Hits          50602    50634      +32     
- Misses        29881    29896      +15     
+ Partials       5530     5520      -10     
Flag Coverage Δ
unit-tests 58.84% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RainYuY
Copy link
Member

RainYuY commented Feb 13, 2025

#15125 It has already been removed.

@zrlw
Copy link
Contributor Author

zrlw commented Feb 13, 2025

#15125 It has already been removed.

it's useless because dubbo depends on dubbo-remoting-http12, dubbo-remoting-http3, ... which depend on dubbo-test-check.
so i think #15082 might be reverted, or seperate dubbo-remoting-zookeeper-curator5 from dubbo-remoting.

@zrlw zrlw force-pushed the patch-dubbo-remoting-api-pom branch from 892ce89 to 1f2a33c Compare February 13, 2025 12:17
@zrlw zrlw changed the title [3.3] remove dubbo-test-check from dubbo-remoting-api [3.3] remove dubbo-test-check from dubbo-remoting-api and set optional of it's dependency to true Feb 13, 2025
@zrlw zrlw force-pushed the patch-dubbo-remoting-api-pom branch from 1f2a33c to 97317ce Compare February 13, 2025 12:52
@zrlw zrlw changed the title [3.3] remove dubbo-test-check from dubbo-remoting-api and set optional of it's dependency to true [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)" Feb 13, 2025
@zrlw
Copy link
Contributor Author

zrlw commented Feb 13, 2025

dubbo-samples-configcenter-apollo at https://github.com/apache/dubbo-samples should be modified before removing dubbo-test module from dubbo-remoting-zookeeper-curator5.

@RainYuY
Copy link
Member

RainYuY commented Feb 13, 2025

dubbo-samples-configcenter-apollo at https://github.com/apache/dubbo-samples should be modified before removing dubbo-test module from dubbo-remoting-zookeeper-curator5.

It is unrelated to this PR. The investigation indicates that it is related to recent changes in Apollo. I will fix the CI issue later.

@zrlw
Copy link
Contributor Author

zrlw commented Feb 13, 2025

oops, dubbo-samples-configcenter-apollo testing result is always timeout no matter revert #15082 or not.

@AlbumenJ
Copy link
Member

Will be fixed in apache/dubbo-samples#1203

@zrlw zrlw closed this Feb 14, 2025
@zrlw zrlw deleted the patch-dubbo-remoting-api-pom branch June 5, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants