-
Notifications
You must be signed in to change notification settings - Fork 26.6k
dubbo-remoting-zookeeper-curator5 module remove dubbo-test-check and dubbo-test-common #15082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dubbo-remoting-zookeeper-curator5 module remove dubbo-test-check and dubbo-test-common #15082
Conversation
357ddd5 to
cc962b9
Compare
cc962b9 to
a10cc18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15082 +/- ##
============================================
- Coverage 60.76% 60.73% -0.04%
+ Complexity 10863 10861 -2
============================================
Files 1882 1882
Lines 86007 86009 +2
Branches 12886 12887 +1
============================================
- Hits 52263 52237 -26
- Misses 28301 28326 +25
- Partials 5443 5446 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@CrazyHZM PTAL |
|
dubbo-test-check otherwise test failure: |
|
why adding dubbo-test-check to dubbo-remoting-api? it seemed that all modules which need dubbo-test-check already set it's dependency in them pom. |
…le (apache#15082)" This reverts commit d8f5406.
What is the purpose of the change?
Checklist