Skip to content

[DSIP-90][plugin] Introduce new task plugin for Flink materialized table #17201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

[DSIP-90][plugin] Introduce new task plugin for Flink materialized table #17201

wants to merge 18 commits into from

Conversation

@hackergin
Copy link

@hackergin hackergin commented May 22, 2025 •
edited by SbloodyS
Loading

Purpose of the pull request

Add a new task plugin for refresh flink materialized table.

close #17086

Brief change log

Verify this pull request

  • Added dolphinscheduler flink materialized table end to end test

@boring-cyborg
Copy link

boring-cyborg bot commented May 22, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@github-actions github-actions bot added UI ui and front end related backend test e2e e2e test labels May 22, 2025
@hackergin hackergin force-pushed the support-flink-materialized-table branch 2 times, most recently from adb610e to 04d013f Compare May 22, 2025 05:51
@lsyldliu
Copy link

lsyldliu commented May 22, 2025

Hi, @ruanwenjun, @SbloodyS can you help review this pr?

@SbloodyS
Copy link
Member

SbloodyS commented May 22, 2025

Please check the failed CI. @hackergin

@SbloodyS SbloodyS added the DSIP label May 22, 2025
@SbloodyS SbloodyS added this to the 3.3.1 milestone May 22, 2025
@hackergin hackergin force-pushed the support-flink-materialized-table branch from 284d06b to ab0a878 Compare May 22, 2025 19:12
@hackergin hackergin force-pushed the support-flink-materialized-table branch 2 times, most recently from 888b7dc to 033c3d4 Compare May 25, 2025 10:59
@github-actions github-actions bot added the CI&CD label Jun 1, 2025
@hackergin hackergin force-pushed the support-flink-materialized-table branch from ab3c85c to 0e1151d Compare June 2, 2025 03:12
@hackergin hackergin requested a review from EricGao888 as a code owner June 15, 2025 15:22
@hackergin hackergin force-pushed the support-flink-materialized-table branch 2 times, most recently from 0032ecd to 5343781 Compare June 16, 2025 16:28
@hackergin hackergin force-pushed the support-flink-materialized-table branch from 5343781 to 55aab6a Compare June 17, 2025 14:47
@github-actions github-actions bot removed the document label Jun 17, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 17, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@hackergin
Copy link
Author

hackergin commented Jun 24, 2025

Two CI issues:

  1. dependency check is failing with Cannot construct instance of ModifiedCiaType, problem: SAFETY - seems like a tool compatibility issue with new NVD data, not related to my changes.

  2. Code coverage is below threshold. Not sure if this is required since I noticed other similar tasks don't seem to have corresponding tests either.

@SbloodyS Should I address the coverage issue or is it OK to proceed as-is?

@SbloodyS
Copy link
Member

SbloodyS commented Jun 30, 2025

  1. You can ignore OWASP Dependentcy Check for now.

Code coverage is below threshold. Not sure if this is required since I noticed other similar tasks don't seem to have corresponding tests either.

Yes.

@SbloodyS SbloodyS removed this from the 3.3.1 milestone Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@Gallardot Gallardot Awaiting requested review from Gallardot Gallardot is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun

@EricGao888 EricGao888 Awaiting requested review from EricGao888

At least 2 approving reviews are required to merge this pull request.

Assignees

@hackergin hackergin

Labels

backend CI&CD DSIP e2e e2e test test UI ui and front end related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DSIP-90][plugin] Introduce new task plugin for Flink materialized table

4 participants

@hackergin @lsyldliu @SbloodyS @EricGao888