Skip to content

Commit 04d013f

Browse files
committed
resolve conflict & fix checkstyle
1 parent 7873915 commit 04d013f

File tree

8 files changed

+87
-22
lines changed

8 files changed

+87
-22
lines changed

dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/WorkflowFlinkMaterializedTableE2ETest.java

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
package org.apache.dolphinscheduler.e2e.cases;
1919

20+
import static org.assertj.core.api.Assertions.assertThat;
21+
2022
import org.apache.dolphinscheduler.e2e.core.DolphinScheduler;
2123
import org.apache.dolphinscheduler.e2e.pages.LoginPage;
2224
import org.apache.dolphinscheduler.e2e.pages.common.NavBarPage;
@@ -30,6 +32,8 @@
3032
import org.apache.dolphinscheduler.e2e.pages.security.TenantPage;
3133
import org.apache.dolphinscheduler.e2e.pages.security.UserPage;
3234

35+
import java.time.Duration;
36+
3337
import org.junit.jupiter.api.AfterAll;
3438
import org.junit.jupiter.api.BeforeAll;
3539
import org.junit.jupiter.api.Order;
@@ -40,12 +44,9 @@
4044
import org.openqa.selenium.support.ui.WebDriverWait;
4145
import org.testcontainers.shaded.org.awaitility.Awaitility;
4246

43-
import java.time.Duration;
44-
45-
import static org.assertj.core.api.Assertions.assertThat;
46-
4747
@DolphinScheduler(composeFiles = "docker/flink-materialized-table/docker-compose.yaml")
4848
class WorkflowFlinkMaterializedTableE2ETest {
49+
4950
private static final String project = "test-workflow-1";
5051
private static final String workflow = "test-workflow-1";
5152
private static final String user = "admin";
@@ -68,13 +69,13 @@ public static void setup() {
6869
.goToNav(SecurityPage.class)
6970
.goToTab(UserPage.class);
7071

71-
new WebDriverWait(userPage.driver(), Duration.ofSeconds(20)).until(ExpectedConditions.visibilityOfElementLocated(
72-
new By.ByClassName("name")));
72+
new WebDriverWait(userPage.driver(), Duration.ofSeconds(20))
73+
.until(ExpectedConditions.visibilityOfElementLocated(
74+
new By.ByClassName("name")));
7375

7476
userPage.update(user, user, email, phone, tenant)
7577
.goToNav(ProjectPage.class)
76-
.create(project)
77-
;
78+
.create(project);
7879
}
7980

8081
@AfterAll
@@ -107,7 +108,7 @@ void testCreateWorkflow() {
107108

108109
workflowDefinitionPage
109110
.createWorkflow()
110-
.<FlinkMaterializedTableTaskForm> addTask(WorkflowForm.TaskType.FLINK_MATERIALIZED_TABLE)
111+
.<FlinkMaterializedTableTaskForm>addTask(WorkflowForm.TaskType.FLINK_MATERIALIZED_TABLE)
111112
.gatewayEndpoint(flinkSqlGatewayUrl)
112113
.identifier(materializedTableIdentifier)
113114
.staticPartitions("{}")
@@ -120,14 +121,12 @@ void testCreateWorkflow() {
120121
.submit()
121122
.name(workflow)
122123
.addGlobalParam("global_param", "hello world")
123-
.submit()
124-
;
124+
.submit();
125125

126126
Awaitility.await().untilAsserted(() -> assertThat(workflowDefinitionPage.workflowList())
127127
.as("Workflow list should contain newly-created workflow")
128128
.anyMatch(
129-
it -> it.getText().contains(workflow)
130-
));
129+
it -> it.getText().contains(workflow)));
131130
workflowDefinitionPage.publish(workflow);
132131
}
133132

@@ -160,4 +159,4 @@ void testRunWorkflow() {
160159
assertThat(row.executionTime()).isEqualTo(1);
161160
});
162161
}
163-
}
162+
}

dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/WorkflowForm.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@
1818
package org.apache.dolphinscheduler.e2e.pages.project.workflow;
1919

2020
import org.apache.dolphinscheduler.e2e.core.WebDriverWaitFactory;
21+
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.FlinkMaterializedTableTaskForm;
2122
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.HttpTaskForm;
2223
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.JavaTaskForm;
2324
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.PythonTaskForm;
2425
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.ShellTaskForm;
2526
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.SubWorkflowTaskForm;
2627
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.SwitchTaskForm;
27-
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.JavaTaskForm;
28-
import org.apache.dolphinscheduler.e2e.pages.project.workflow.task.FlinkMaterializedTableTaskForm;
2928

3029
import java.nio.charset.StandardCharsets;
3130
import java.util.List;

dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/task/FlinkMaterializedTableTaskForm.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717

1818
package org.apache.dolphinscheduler.e2e.pages.project.workflow.task;
1919

20-
import lombok.Getter;
2120
import org.apache.dolphinscheduler.e2e.pages.project.workflow.WorkflowForm;
22-
import org.openqa.selenium.By;
21+
22+
import lombok.Getter;
23+
2324
import org.openqa.selenium.WebDriver;
2425
import org.openqa.selenium.WebElement;
2526
import org.openqa.selenium.support.FindBy;
@@ -29,14 +30,13 @@
2930
@Getter
3031
public final class FlinkMaterializedTableTaskForm extends TaskNodeForm {
3132

32-
3333
@FindBys({
3434
@FindBy(className = "input-identifier"),
3535
@FindBy(tagName = "input"),
3636
})
3737
private WebElement inputIdentifier;
3838

39-
@FindBys({
39+
@FindBys({
4040
@FindBy(className = "input-gateway-endpoint"),
4141
@FindBy(tagName = "input"),
4242
})
@@ -103,4 +103,4 @@ public FlinkMaterializedTableTaskForm executionConfig(String executionConfig) {
103103
executionConfig().sendKeys(executionConfig);
104104
return this;
105105
}
106-
}
106+
}

dolphinscheduler-task-plugin/dolphinscheduler-task-all/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,6 @@
216216
<version>${project.version}</version>
217217
</dependency>
218218
<dependency>
219-
<version>${project.version}</version>
220219
<groupId>org.apache.dolphinscheduler</groupId>
221220
<artifactId>dolphinscheduler-task-flink-materialized-table</artifactId>
222221
<version>${project.version}</version>

dolphinscheduler-task-plugin/dolphinscheduler-task-flink-materialized-table/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/gateway/model/FetchResultResponseBodyImpl.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
118
package org.apache.dolphinscheduler.plugin.task.flink.gateway.model;
219

320
import java.util.List;

dolphinscheduler-task-plugin/dolphinscheduler-task-flink-materialized-table/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/gateway/model/SqlGatewayResponseImpl.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
118
package org.apache.dolphinscheduler.plugin.task.flink.gateway.model;
219

320
import java.util.List;

dolphinscheduler-task-plugin/dolphinscheduler-task-flink-materialized-table/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/gateway/serde/FetchResultResponseBodyDeserializer.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
118
package org.apache.dolphinscheduler.plugin.task.flink.gateway.serde;
219

320
import org.apache.dolphinscheduler.plugin.task.flink.gateway.model.FetchResultResponseBody;

dolphinscheduler-task-plugin/dolphinscheduler-task-flink-materialized-table/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/gateway/serde/FetchResultResponseBodySerializer.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one or more
3+
* contributor license agreements. See the NOTICE file distributed with
4+
* this work for additional information regarding copyright ownership.
5+
* The ASF licenses this file to You under the Apache License, Version 2.0
6+
* (the "License"); you may not use this file except in compliance with
7+
* the License. You may obtain a copy of the License at
8+
*
9+
* http://www.apache.org/licenses/LICENSE-2.0
10+
*
11+
* Unless required by applicable law or agreed to in writing, software
12+
* distributed under the License is distributed on an "AS IS" BASIS,
13+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
* See the License for the specific language governing permissions and
15+
* limitations under the License.
16+
*/
17+
118
package org.apache.dolphinscheduler.plugin.task.flink.gateway.serde;
219

320
import org.apache.dolphinscheduler.plugin.task.flink.gateway.model.FetchResultResponseBody;

0 commit comments

Comments
 (0)