Add additional tests for InListExpr #19050
Open
+837
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I expect tests to fail. We can fix them once we confirm. |
adriangb
commented
Dec 3, 2025
Comment on lines
+230
to
+237
| downcast_dictionary_array! { | ||
| v => { | ||
| let values_contains = self.contains(v.values().as_ref(), negated)?; | ||
| let result = take(&values_contains, v.keys(), None)?; | ||
| return Ok(downcast_array(result.as_ref())) | ||
| } | ||
| _ => {} | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The lack of this was a bug
Comment on lines
-233
to
-237
| let result = match (v.null_count() > 0, negated) { | ||
| (true, false) => { | ||
| // has nulls, not negated" | ||
| BooleanArray::from_iter( | ||
| v.iter().map(|value| Some(self.values.contains(&value?))), |
Contributor
Author
There was a problem hiding this comment.
We were not handling nulls properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests that prove some bugs that are fixed in #18832 so we can level the playing field on benchmarks.