Remove uneeded Mutex in Ballista Client #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Mar 1, 2022
viirya
approved these changes
Mar 3, 2022
alamb
force-pushed
the
alamb/clean_up_mutex
branch
from
bccd43d to
8c77be3
Compare
Contributor
Author
|
Rebased |
Contributor
Author
|
cc @tustvold who pointed out this mess initially |
Contributor
Author
|
And thanks again to @doki23 for unlocking this cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1884, so draft until that is merged
Which issue does this PR close?
re: #1614
Rationale for this change
I added a somewhat nasty
Mutexworkaround in #1523 due to some changes in how prost / tonic. Now that @doki23 has updated theSendableRecordBatchStreamin #1884 this workaround can be removedI don't think removing this
Mutexhas any practical performance implications, but it makes the code cleanerWhat changes are included in this PR?
Are there any user-facing changes?
No